New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using User.is_authenticated() as a callable is deprecated since Django 1.10 and removed in Django 2.x. #148

Closed
wants to merge 1 commit into
base: master
from

Conversation

3 participants
@lamby

lamby commented Nov 11, 2017

No description provided.

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Nov 11, 2017

Codecov Report

Merging #148 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   69.15%   69.34%   +0.19%     
==========================================
  Files          18       18              
  Lines         483      486       +3     
==========================================
+ Hits          334      337       +3     
  Misses        149      149
Impacted Files Coverage Δ
src/auditlog/middleware.py 72.72% <100%> (+1.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45760c6...24c17c3. Read the comment docs.

codecov-io commented Nov 11, 2017

Codecov Report

Merging #148 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #148      +/-   ##
==========================================
+ Coverage   69.15%   69.34%   +0.19%     
==========================================
  Files          18       18              
  Lines         483      486       +3     
==========================================
+ Hits          334      337       +3     
  Misses        149      149
Impacted Files Coverage Δ
src/auditlog/middleware.py 72.72% <100%> (+1.99%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45760c6...24c17c3. Read the comment docs.

@audiolion

This comment has been minimized.

Show comment
Hide comment
@audiolion

audiolion Nov 13, 2017

Collaborator

Thanks, soon ill address Django support and get to your PRs

Collaborator

audiolion commented Nov 13, 2017

Thanks, soon ill address Django support and get to your PRs

@lamby

This comment has been minimized.

Show comment
Hide comment
@lamby

lamby Nov 15, 2017

@audiolion Why not merge in the meantime, out of interest? :)

lamby commented Nov 15, 2017

@audiolion Why not merge in the meantime, out of interest? :)

@audiolion

This comment has been minimized.

Show comment
Hide comment
@audiolion

audiolion Nov 15, 2017

Collaborator

I dont have the ability to cut deployments, and I would like to get some current stuff that has been merged released in 0.5.0 before we do a compat update

Collaborator

audiolion commented Nov 15, 2017

I dont have the ability to cut deployments, and I would like to get some current stuff that has been merged released in 0.5.0 before we do a compat update

@lamby

This comment has been minimized.

Show comment
Hide comment
@lamby

lamby commented Nov 15, 2017

@audiolion Nod. thanks!

@audiolion

This comment has been minimized.

Show comment
Hide comment
@audiolion

audiolion Jan 2, 2018

Collaborator

this was resolved in #154

Collaborator

audiolion commented Jan 2, 2018

this was resolved in #154

@audiolion audiolion closed this Jan 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment