Permalink
Browse files

Disambiguate left/right, document ->keys, make Kwalitee test autoskip

  • Loading branch information...
1 parent 338528f commit c046e43bac2ee5d992f30a7532128dc1da10f04e @kentfredric kentfredric committed Sep 12, 2009
Showing with 12 additions and 4 deletions.
  1. +7 −3 lib/Spark/Form.pm
  2. +5 −1 xt/author/kwalitee.t
View
@@ -292,13 +292,13 @@ sub clone_except_names {
}
sub _except {
- my ($self, $left, $right) = @_;
+ my ($self, $input_list, $exclusion_list) = @_;
my %d;
- @d{@{$left}} = ();
+ @d{@{$input_list}} = ();
return grep {
!defined $d{$_}
- } @{$right};
+ } @{$exclusion_list};
}
sub clone_only_names {
@@ -473,6 +473,10 @@ Returns the form field of that name
Returns the form field at that index (counting from 0)
+=head2 keys () :: Array
+
+Returns the field names
+
=head2 field_couplet () :: Data::Couplet
Returns the Data::Couplet used to store the fields. Try not to use this too much.
@@ -1,6 +1,10 @@
-
use strict;
use warnings;
use Test::More;
+
+BEGIN {
+ eval { require Test::Kwalitee; 1 }
+ or plan skip_all => "You need Test::Kwalitee installed to run this test. Its only an authortest though, so thats ok";
+}
use Test::Kwalitee tests => [qw( -use_strict )];

0 comments on commit c046e43

Please sign in to comment.