New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass fixtures obj init args and class instead of obj in ENV closes #59 #68

Merged
merged 1 commit into from Jan 7, 2016

Conversation

Projects
None yet
2 participants
@SysPete
Contributor

SysPete commented Dec 2, 2015

Rationale: As of Perl v5.18.0, both keys and values stored in %ENV are stringified.
GH Issue: #59

DCM used to pass DBIC::Fixtures obj via ENV to runscripts and this fails for Perl >= 5.18. This patch instead passes just the init args and the fixtures class via ENV and the fixtures object is constructed in the Dump and Populate traits.

All tests passing locally for 5.14.4, 5.20.2, 5.20.3 and 5.22.0

@SysPete SysPete referenced this pull request Dec 2, 2015

Closed

MySQL test fails #60

@SysPete SysPete referenced this pull request Dec 22, 2015

Closed

Can't run #59

jjn1056 added a commit that referenced this pull request Jan 7, 2016

Merge pull request #68 from SysPete/gh-issue-59
pass fixtures obj init args and class instead of obj in ENV closes #59

@jjn1056 jjn1056 merged commit 4f2fe31 into jjn1056:master Jan 7, 2016

@SysPete

This comment has been minimized.

Show comment
Hide comment
@SysPete

SysPete Jan 7, 2016

Contributor

Just noticed you merged another PR which changes JSON::XS to JSON::MaybeXS but my PR uses JSON::XS so I'll rebase and submit another PR asap.

Contributor

SysPete commented Jan 7, 2016

Just noticed you merged another PR which changes JSON::XS to JSON::MaybeXS but my PR uses JSON::XS so I'll rebase and submit another PR asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment