Remove __bounded__ function attributes #22
Closed
+48
−104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only specific older versions of the GCC compiler (mostly OpenBSD-specific versions) used the __bounded__ function attributes. Since we're really only compiling the lamp/MacRelix headers with either Codewarrior or Retro68, there really isn't much reason to leave them in the tree. At best, they're ignored (by Metrowerks), and at worst they cause nasty compile-time errors (any modern GCC like the one in Retro68's toolchain).
|
Thanks! I tweaked the commit message slightly and pushed it on top of my local master as 584279b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Only specific older versions of the GCC compiler (mostly OpenBSD-specific versions) used the bounded function attributes.
Since we're really only compiling the lamp/MacRelix headers with either Codewarrior or Retro68, there really isn't much reason to leave them in the tree. At best, they're ignored (by Metrowerks), and at worst they cause nasty compile-time errors (any modern GCC like the one in Retro68's toolchain).