Jason Choy jjwchoy

  • Joined on
jjwchoy commented on pull request sandstorm-io/capnproto#188
@jjwchoy

Sounds good to me. Should AsyncFd and AsyncStreamFd live in async-unix? I haven't even attempted to support signals yet.

jjwchoy commented on pull request sandstorm-io/capnproto#188
@jjwchoy

if UnixEventPort were an abstract interface, would you be able to implement CFRunLoop support at that level to avoid re-implementing AsyncIoStream?

jjwchoy commented on pull request jjwchoy/mongoose-shortid#10
@jjwchoy

This PR has far too much in. Please remove the node_modules dir and I'll take a look. Could you also describe what's changed as well as the rationa…

jjwchoy commented on pull request jjwchoy/mongoose-shortid#14
@jjwchoy

Hi @nikolay, sorry for the long delay in response. This looks good, please also bump the mongoose patch version number in package.json and I'll mer…

jjwchoy commented on pull request jjwchoy/mongoose-shortid#16
@jjwchoy

Thanks!

@jjwchoy
jjwchoy merged pull request jjwchoy/mongoose-shortid#16
@jjwchoy
Create a variable in scope to avoid being override
1 commit with 2 additions and 1 deletion
jjwchoy commented on pull request jjwchoy/mongoose-shortid#15
@jjwchoy

Makes sense. Thanks

@jjwchoy
jjwchoy merged pull request jjwchoy/mongoose-shortid#15
@jjwchoy
Callbacks aren't required by mongoose, so don't fail without callbacks
1 commit with 6 additions and 2 deletions
jjwchoy commented on pull request sandstorm-io/capnproto#188
@jjwchoy

Hi Kenton, Your suggestions sound good. Regarding CoreFoundation an gcc, perhaps these compat libraries should not be part of the default make targ…

jjwchoy closed pull request sandstorm-io/capnproto#91
@jjwchoy
Added eventloop integration with CFRunLoop (OSX/iOS)
jjwchoy commented on pull request sandstorm-io/capnproto#91
@jjwchoy

Opened a new pull request for this: #188

@jjwchoy
  • @jjwchoy df8a37b
    Added tests, and updated CocoaEventPort for recent EventPort interface
@jjwchoy
@jjwchoy
jjwchoy opened pull request sandstorm-io/capnproto#188
@jjwchoy
Async cocoa 2
4 commits with 646 additions and 20 deletions
@jjwchoy
@jjwchoy

Hi @nikolay. I don't have much free time at the moment to spend on this project (or node.js). If you have a fix for this I'll give it a superficial…

jjwchoy created branch master at jjwchoy/hotdb
jjwchoy created repository jjwchoy/hotdb
jjwchoy commented on issue ably/docs#1
@jjwchoy

Looks good to me On 12 Dec 2014 18:38, "mattheworiordan" notifications@github.com wrote: @jjwchoy https://github.com/jjwchoy and @paddybyers https…

jjwchoy commented on pull request kentonv/capnproto#91
@jjwchoy

Ok, that sounds good - my original thinking was that I would be providing a platform-specific setupAsyncIo() implementation, however I failed to re…