Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default image for all episodes too repetitive #5

Closed
jkaplon opened this issue Feb 10, 2015 · 3 comments
Closed

Default image for all episodes too repetitive #5

jkaplon opened this issue Feb 10, 2015 · 3 comments

Comments

@jkaplon
Copy link
Owner

jkaplon commented Feb 10, 2015

Using high-five hand for all episodes is too visually-repetitive.
Get episode-specific images from...somewhere.
@jkaplon
Copy link
Owner Author

jkaplon commented Feb 10, 2015

Version of Ghost blog platform currently running http://gtradio.net/alyt supports post images.
These can be the canonical source for episode images.
Android app can be changed to use Ghost post images instead of feed images (this will save time on feed maintenance since I'm still updating it by hand).

@jkaplon
Copy link
Owner Author

jkaplon commented Feb 10, 2015

Never mind, can't use post images from Ghost.
They are a nice feature (they show up instead of the blog banner image on the post's page...if theme supports it, and our older theme does not).

Anyway, post images do not show up in RSS feed generated by Ghost and currently no external API available to access them.

Will have to add episode images directly to feed.

@jkaplon
Copy link
Owner Author

jkaplon commented Feb 10, 2015

Added google plus image link to test feed for e51, nothing broke.
Image did not show up in PocketCasts or AntennaPod on android (which is ok).

Added same image link (taken from e51 show notes page) to e51 in main feed.
Asked Matt to compile image links for other episodes.

@jkaplon jkaplon mentioned this issue Feb 11, 2015
Closed
jkaplon added a commit that referenced this issue Feb 13, 2015
@jkaplon
Remove dup image check, download episode images from feed.
6a380cc 
issue #5
- Remove duplicate image check, still want to get episode images from feed (even if more than one episode set to default image)
- Try to avoid download of kaplon.us/alyt.jpg (used as default episode image in feed)
    - Use previously cached feed image instead (already contains kaplon.us/alyt.jpg)
- App still trying to repeatedly downlaod kaplon.us/alyt.jpg, not sure why
    - Episode listing shows some instances of default images, most are blank
    - Asked Matt to compile list of image links for all episodes to work around this issue
jkaplon added a commit that referenced this issue Feb 13, 2015
@jkaplon
Remove dup image check, download episode images from feed.
02e088f 
issue #5
- Remove duplicate image check, still want to get episode images from feed (even if more than one episode set to default image)
- Try to avoid download of kaplon.us/alyt.jpg (used as default episode image in feed)
    - Use previously cached feed image instead (already contains kaplon.us/alyt.jpg)
- App still trying to repeatedly downlaod kaplon.us/alyt.jpg, not sure why
    - Episode listing shows some instances of default images, most are blank
    - Asked Matt to compile list of image links for all episodes to work around this issue
- Commit 6a380cc used wrong file, overwrite bad commit with correct version of DownloadService.java
@jkaplon jkaplon mentioned this issue Feb 14, 2015
Closed
@jkaplon jkaplon closed this as completed Feb 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jkaplon