Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in the old_style logic in its own functions #8

Open
wants to merge 2 commits into
base: master
from

Conversation

@yanick
Copy link

@yanick yanick commented Dec 9, 2018

Centralizes the definition of what is old style in __is_old_style and simplify mkpath by pushing the old_style code in its own inner sub.

(this PR is part of the CPAN PR Challenge)

@jkeenan
Copy link
Owner

@jkeenan jkeenan commented Dec 9, 2018

@yanick I'm not going to apply this pull request at this time. My policy with File::Path going forward is to make as few changes as possible so as to minimize the risk of additional security problems.

I'll keep the p.r. open for future reference. Thanks for taking a look at this godforsaken code.

@yanick
Copy link
Author

@yanick yanick commented Dec 9, 2018

Fair enough! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants