New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix contribution: performance improvement for _subset_subengine #6

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@pauloscustodio
Contributor

pauloscustodio commented Jun 6, 2015

Commit ID 2bd876c has a
performance improvement in _subset_subengine, but has a minor
bug - a swapped index in an array access.

Fixed the bug and added tests for special cases: empty arrays and
disjoint arrays.

Fix contribution: performance improvement for _subset_subengine
Commit ID 2bd876c has a
performance improvement in _subset_subengine, but has a minor
bug - a swapped index in an array access.

Fixed the bug and added tests for special cases: empty arrays and
disjoint arrays.
@jkeenan

This comment has been minimized.

Show comment
Hide comment
@jkeenan

jkeenan Jun 7, 2015

Owner

Did you fork from HEAD in master ... or from v0.50?

Owner

jkeenan commented Jun 7, 2015

Did you fork from HEAD in master ... or from v0.50?

@pauloscustodio

This comment has been minimized.

Show comment
Hide comment
@pauloscustodio

pauloscustodio Jun 7, 2015

Contributor

I've forked from HEAD in master.
Em 07/06/2015 05:00, "James E Keenan" notifications@github.com escreveu:

Did you fork from HEAD in master ... or from v0.50?


Reply to this email directly or view it on GitHub
#6 (comment).

Contributor

pauloscustodio commented Jun 7, 2015

I've forked from HEAD in master.
Em 07/06/2015 05:00, "James E Keenan" notifications@github.com escreveu:

Did you fork from HEAD in master ... or from v0.50?


Reply to this email directly or view it on GitHub
#6 (comment).

@jkeenan

This comment has been minimized.

Show comment
Hide comment
@jkeenan

jkeenan Jun 7, 2015

Owner

Thanks. Accepted as patch. Slight typographic corrections. Added to ADDITIONAL CONTRIBUTORS. Benchmarked to confirm performance improvements. Uploaded to CPAN in version 0.53.

Owner

jkeenan commented Jun 7, 2015

Thanks. Accepted as patch. Slight typographic corrections. Added to ADDITIONAL CONTRIBUTORS. Benchmarked to confirm performance improvements. Uploaded to CPAN in version 0.53.

@jkeenan jkeenan closed this Jun 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment