Fix connection errors when paginating -- fixes #120 #125

Merged
merged 1 commit into from Nov 15, 2016

Projects

None yet

3 participants

@centralniak
Contributor

Solution to #120 provided in #121 does not pass travis tests, so I'm opening this. It uses six to get urlparse from the right location.

@centralniak centralniak Fix connection errors when paginating -- fixes #120
d067b34
@@ -30,7 +30,7 @@ def it_keeps_iterating_if_next_link(self):
side_effect = [page1, page2]
with patch.object(Client, 'get', side_effect=side_effect) as mock_method: # noqa
emails = [user.email for user in self.client.users.all()]
- eq_([call('/users', {}), call('https://api.intercom.io/users?per_page=50&page=2', {})], # noqa
@centralniak
centralniak Nov 3, 2016 Contributor

A request with a hostname will fail.

@coveralls
coveralls commented Nov 3, 2016 edited

Coverage Status

Coverage increased (+0.006%) to 95.241% when pulling d067b34 on TyMaszWeb:fix-next-page into 026d22f on jkeyes:version-3.

@jkeyes jkeyes merged commit c668289 into jkeyes:version-3 Nov 15, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 95.241%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment