New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

escape Object other than String too #167

merged 1 commit into from May 2, 2013


None yet
2 participants

akr4 commented May 2, 2013


When a value which has toString() returns HTML unsafe characters is referenced, does not escape it.

This is a pull request to solve that. I don't understand why Handlebars only escape CharSequence and Character, but the patch works fine in my environment and passed the testcases.



This comment has been minimized.


jknack commented May 2, 2013

make sense, thanks for contributing :)

jknack added a commit that referenced this pull request May 2, 2013

Merge pull request #167 from akr4/escape-tostring
escape Object other than String too

@jknack jknack merged commit 22d1d66 into jknack:master May 2, 2013

1 check passed

default The Travis build passed

@akr4 akr4 deleted the akr4:escape-tostring branch May 4, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment