Bug in FindCallingMethodOnStackTrace wrt wrapping logger #15

Open
wants to merge 2 commits into
from

2 participants

@aloker

Added unit test that shows a bug in FindCallingMethodOnStackTrace: using a wrapper type only works if no method on a different type is present on the callstack between the wrapper type method and the NLog method.

E.g. it's not possible to get a proper stack trace when wrapping NLog 2 for Common.Logging.

I'll try to come up with a fix.

aloker added some commits Feb 3, 2012
@aloker aloker Added unit test that shows a bug in FindCallingMethodOnStackTrace: us…
…ing a wrapper type only works if no method on a different type is present on the callstack between the wrapper type method and the NLog method.
a75539b
@aloker aloker Proposed solution for the issue shown in the previous commit 530d8e5
@aloker

Proposed solution added.

Issue http://nlog.codeplex.com/workitem/6737

@Xharze

This has been fixed in NLog/NLog@08183ad

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment