New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

svg-sprite - exceoption 'has no method 'size' ' #2

Closed
stefanjudis opened this Issue Feb 19, 2014 · 6 comments

Comments

2 participants
@stefanjudis
Contributor

stefanjudis commented Feb 19, 2014

Hey,

I'm running the following command, copied from your readme:

★ svg-sprite --keep --dims --css --out sprite --cleanwith svgo ./ingredients                               
Converting the SVG files in directory "./ingredients" to an SVG sprite ...
[TypeError: Object  has no method 'size']
An uncaughtException was found, svg-sprite will end.

Had the same bug by using it via grunt-svg-sprite.

Thanks. :)

@jkphl

This comment has been minimized.

Owner

jkphl commented Feb 19, 2014

Hi Stefan,

could you please provide me the SVG files that you are experimenting with? Thanks!

Joschi

@stefanjudis

This comment has been minimized.

Contributor

stefanjudis commented Feb 19, 2014

I haven't had a look into them. I'm just playing around. ;)

https://gist.github.com/stefanjudis-pa/43426e236bc3468c0136

@jkphl

This comment has been minimized.

Owner

jkphl commented Feb 19, 2014

Should be fixed with 4c75621, new nmpjs.org release on it's way. :)

@jkphl jkphl closed this Feb 19, 2014

@jkphl

This comment has been minimized.

Owner

jkphl commented Feb 19, 2014

There's still a problem with your test SVGs when using Scour as cleaner module, which seems to be a Scour problem though. Will get into this now ..

@stefanjudis

This comment has been minimized.

Contributor

stefanjudis commented Feb 19, 2014

Man you're quick. 👍

But shouldn't it use svgo? -> --cleanwith svgo

@jkphl

This comment has been minimized.

Owner

jkphl commented Feb 19, 2014

There has been an additional bug so that the binary version of svg-sprite always used Scour (regardless of your setting), but I fixed this with the latest release as well. However, I noticed that Scour has an additional problem with your test files. That's why I'm already about submitting a pull request for svg-cleaner ... ;)

@jkphl jkphl added the bug label May 27, 2014

@jkphl jkphl self-assigned this May 27, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment