Skip to content


Subversion checkout URL

You can clone with
Download ZIP
Commits on May 27, 2012
  1. @drogus

    Fix sorting of helpers from different paths

    drogus authored
    When more than one directory for helpers is provided to a controller, it
    should preserver the order of directories. Given 2 paths:
        MyController.helpers_paths = ["dir1/helpers", "dir2/helpers"]
    helpers from dir1 should be loaded first. Before this commit, all
    helpers were mixed and then sorted alphabetically, which essentially
    would require to rename helpers to get desired order.
    This is a problem especially for engines, where you would like to be
    able to predict accurately which engine helpers will load first.
  2. @drogus

    Fix railties_order when application object is passed

    drogus authored
    railites_order method, introduced in 40b19e0, had a bug that was causing
    loading application instance twice in initializers if railties_order
    already included application instance. So for example
        railties_order = [Foo::Engine, :main_app, Bar::Engine]
    would result in such railties array:
        [MyApp::Application, Foo::Engine, MyAppApplication, Bar::Engine]
    In order to fix it, we need to check for existence of application in
    both railties_order and railties arrays.
Commits on May 22, 2012
  1. @drogus

    Use require_dependency in generated controllers

    drogus authored
    Using require in development mode will prevent required files from
    reloading, even if they're changed. In order to keep namespaced
    application_controller reloadable, we need to use require_dependency
    instead of require.
Commits on May 21, 2012
  1. @tenderlove

    Merge pull request #6418 from pwnall/pgsql_bytea_limit3

    tenderlove authored
    Postgresql doesn't accept limits on binary (bytea) columns (for 3-2-stable)
  2. @carlosantoniodasilva

    Merge pull request #6423 from lest/patch-2

    carlosantoniodasilva authored
    assets: don't add extension if other given and file exists
  3. @lest

    Assets: don't add extension if other given and file exists

    lest authored
    We should lookup if asset without appended extension exists.
    When sprockets are disabled the asset tag helpers incorporate
    this logic. When sprockets are enabled we should have the same
    For example, we have style.ext file in app/assets/stylesheets and
    we use stylesheet_link_tag in the layout. In this case we should
    have /assets/style.ext instead of /assets/style.ext.css in the
    Closes #6310
  4. @pwnall
  5. @drogus

    More info on commit messages in contributing guide

    drogus authored
    Add more info on how to write a good commit messages along with
    example showing nicely formatted commit message.
    Rails git history does not look too well when you try to figure out why
    particular changes were introduced. We can do much better than that and
    it's never too late to start.
  6. @drogus

    Fix generators to help with ambiguous `ApplicationController` issue

    drogus authored
    In development mode, dependencies are loaded dynamically at runtime,
    using `const_missing`. Because of that, when one of the constants is
    already loaded and `const_missing` is not triggered, user can end up
    with unexpected results.
    Given such file in an Engine:
    module Blog
      class PostsController < ApplicationController
    If you load it first, before loading any application files, it will
    correctly load `Blog::ApplicationController`, because second line will
    hit `const_missing`. However if you load `ApplicationController` first,
    the constant will be loaded already, `const_missing` hook will not be
    fired and in result `PostsController` will inherit from
    `ApplicationController` instead of `Blog::ApplicationController`.
    Since it can't be fixed in `AS::Dependencies`, the easiest fix is to
    just explicitly load application controller.
    closes #6413
Commits on May 20, 2012
  1. @rafaelfranca

    Merge pull request #6410 from Bodacious/tag_helper_data_fix_3-2-stable

    rafaelfranca authored
    TagHelper creates invalid data attributes when value is a BigDecimal
  2. @josevalim

    Merge pull request #6407 from pinetops/565c1b0a0772ac6cf91c77e9285806…

    josevalim authored
    Template concurrency fixes
  3. @Bodacious
  4. @pinetops
  5. @drogus
  6. @drogus

    Fix uniqueness validator with `allow_nil: false` also for mysql

    drogus authored
    MySQL's adapter was changing value for case sensitive comparison. We
    don't need to do it for `nil`.
  7. @drogus

    Fix `validates_uniqueness_off :field, :allow_nil => false`

    drogus authored
    Closes (#5853)
    Uniqueness validator was not properly checking if there are any existing
    records, when value was `nil` and column was text type. `nil` was
    converted to string, which resulted in queries looking like:
    SELECT 1 FROM "posts" WHERE "posts"."title" = '' LIMIT 1
    instead of
    SELECT 1 FROM "posts" WHERE "posts"."title" IS NULL LIMIT 1
Commits on May 19, 2012
  1. @carlosantoniodasilva

    Use right option for excerpt text helper in tests, fix build

    carlosantoniodasilva authored
    `excerpt` text helper uses `:radius`, not `line_width` (that is used by
    `word_wrap` helper).
    Also cleanup some whitespaces.
  2. @tenderlove

    Merge pull request #6398 from pmahoney/threadsafe-connection-pool

    tenderlove authored
    Synchronize read and modification of @reserved_connections
  3. @drogus

    Ensure that CollectionAssociation#replace returns proper target

    drogus authored
    The fix commited in e2a070c was returning the `new_target`, as
    a try to return whatever user replaced association with. The
    problem is, the resulting association target may be ordered
    differently. In such case we want to return the target that
    will be later used for that association.
Commits on May 18, 2012
  1. @josevalim @rafaelfranca

    Merge pull request #5020 from KL-7/fix-blank-image_tag-source

    josevalim authored rafaelfranca committed
    Render img tag with empty src if empty string is passed to image_tag.
  2. @rafaelfranca

    Merge pull request #6390 from ernie/invalid-ruby18-syntax-in-habtm

    rafaelfranca authored
    Invalid ruby18 syntax in habtm
  3. @ernie
  4. @jonleighton
  5. @jonleighton

    Perf: Don't load the association for #delete_all.

    jonleighton authored
    Bug #6289
  6. @rafaelfranca

    Merge pull request #6377 from ihid/depreciate_old_text_helper_apis

    rafaelfranca authored
    Deprecate old APIs for highlight, excerpt and word_wrap
  7. @iHiD
Commits on May 17, 2012
  1. @vijaydev

    Merge pull request #6367 from frodsan/fix_validators_docs

    vijaydev authored
    Fix validators docs [3-2-stable]
  2. fix validations docs

    Francesco Rodriguez authored
  3. @drogus

    Fix CollectionAssociation#replace to return new target (closes #6231)

    drogus authored
Commits on May 16, 2012
  1. @tenderlove

    Merge pull request #6340 from bcardarella/patch-3

    tenderlove authored
    Changing the indentation level of the block comment close for Sass
  2. @bcardarella

    Changing the indentation level of the block comment close for SASS

    bcardarella authored
    If one wants to use use SASS for application.css.sass the comment block indentation is invalid.
Commits on May 15, 2012
  1. @rafaelfranca

    Merge pull request #6329 from acapilleri/backport_dup_validation_3_2

    rafaelfranca authored
    Backport dup validation 3 2
  2. add backport for the pull request #6324

    Angelo Capilleri authored
  3. @carlosantoniodasilva
  4. @rafaelfranca
Something went wrong with that request. Please try again.