Permalink
Commits on Jan 10, 2015
  1. Stop passing a column to `quote` in `Relation#to_sql`

    I'm planning on deprecating the column argument to mirror the
    deprecation in [arel].
    
    [arel]: rails/arel@6160bfb
    sgrif committed Jan 10, 2015
  2. Stop passing a column to `quote` when prepared statements are turned off

    I'm planning on deprecating the column argument to mirror the
    deprecation in [arel].
    
    [arel]: rails/arel@6160bfb
    sgrif committed Jan 10, 2015
  3. Merge pull request #18440 from robertomiranda/patch-3

    Fix Typo SecureToken [ci skip]
    guilleiguaran committed Jan 10, 2015
  4. Stop passing a column to `quote` in `insert_fixture`

    I'm planning on deprecating the column argument to mirror the
    deprecation in [arel].
    
    [arel]: rails/arel@6160bfb
    sgrif committed Jan 10, 2015
  5. Stop special casing null binary data in logging

    There's very little value in logging "<NULL binary data>" instead of
    just "nil". I'd like to remove the column from the equation entirely,
    and this case is preventing us from doing so.
    sgrif committed Jan 10, 2015
  6. Don't attempt to save dirty attributes which are not persistable

    This sets a precident for how we handle `attribute` calls, which aren't
    backed by a database column. We should not take this as a conscious
    decision on how to handle them, and this can change when we make
    `attribute` public if we have better ideas in the future.
    
    As the composed attributes API gets fleshed out, I expect the
    `persistable_attributes` method to change to
    `@attributes.select(&:persistable).keys`, or some more performant
    variant there-of. This can probably go away completely once we fully
    move dirty checking into the attribute objects once it gets moved up to
    Active Model.
    
    Fixes #18407
    sgrif committed Jan 10, 2015
  7. Better fork detection in ActiveSupport::Testing::Isolation

    Process.respond_to?(:fork) returns false if fork is not available.
    More on http://www.ruby-doc.org/core-2.0.0/Process.html#method-c-fork
    deepj committed Jan 10, 2015
  8. Use IO::NULL always

    nobu committed with senny Jan 7, 2015
  9. Merge pull request #18433 from koraktor/patch-1

    Fix typo in PostresSQLAdapter's documentation [ci skip]
    senny committed Jan 10, 2015
  10. Remove note about supported plugins from the releasing docs

    The last supported plugin on the list was protected_attributes, which is
    not going to be supported anymore on Rails 5.
    
    [ci skip]
    carlosantoniodasilva committed Jan 9, 2015
Commits on Jan 9, 2015
  1. Merge pull request #18347 from robertomiranda/has_secure_token_base62

    Switching SecureTokens to Base58
    guilleiguaran committed Jan 9, 2015
  2. Switch Secure Token generation to Base58

    Update Secure Token Doc [ci skip]
    
    remove require securerandom, core_ext/securerandom already do that ref 7e00605
    robertomiranda committed Jan 9, 2015
  3. Merge pull request #10690 from robertomiranda/remove_mass_assignment_…

    …security
    
    Remove attributes_protected_by_default reference
    guilleiguaran committed Jan 9, 2015
  4. Add missing require

    guilleiguaran committed Jan 9, 2015
  5. Remove attributes_protected_by_default reference, since MassAssignmen…

    …tSecurity was removed from ActiveModel f8c9a4d
    robertomiranda committed May 20, 2013
  6. Add SecureRandom.base58

    guilleiguaran committed Jan 9, 2015
  7. Merge pull request #18426 from arthurnn/txn_ref

    Copy records to parent transaction should happen on TransactionManager
    chancancode committed Jan 9, 2015
  8. Copy records to parent transaction should happen on TransactionManager

    It is up to the TransactionManager keep the state of current transaction, so after it commits it needs to copy any remaning record to the next current transaction
    arthurnn committed Jan 9, 2015
  9. Merge pull request #18425 from arthurnn/kargs_transaction

    Use keyword args on committed! and rolledback!
    rafaelfranca committed Jan 9, 2015
  10. Use keyword args on committed! and rolledback!

    As discussed before, those methods should receive a keyword args instead of just parameters
    arthurnn committed Jan 9, 2015
  11. Properly copy nested bind values from subqueried relations

    This is cropping up all over the place. After a brief dive, I'm really
    not sure why we have `arel.bind_values` at all. A cursory grep didn't
    reveal where they're actually being assigned (it's definitely in AR, not
    in Arel). I'd like to dig further into it, as I'm fairly certain we
    don't actually need it, we just need a way for the predicate builder to
    communicate merged binds upstream.
    
    Fixes #18414
    sgrif committed Jan 9, 2015
  12. Properly persist `lock_version` as 0 if the DB has no default

    The reason this bug occured is that we never actually check to see if
    this column has changed from it's default, since it was never assigned
    and is not mutable.
    
    It appears I was wrong in b301c40, with
    my statement of "there is no longer a case where a given value would
    differ from the default, but would not already be marked as changed."
    
    However, I chose not to revert the deletion of
    `initialize_internals_callback` from that commit, as I think a solution
    closer to where the problem lies is less likely to get erroneously
    removed. I'm not super happy with this solution, but it mirrors what is
    being done in `_update_record`, and a fix for one should work for the
    other.
    
    I toyed with the idea of changing the definition of `changed?` on the
    type to `changed_in_place?`. If we type cast the raw value, it'll break
    a test about updating not modifying the lock column if nothing else was
    changed. We could have the definition check if `raw_old_value` is `nil`,
    but this feels fragile and less intention revealing. It would, however,
    have the benefit of cleaning up old data that incorrectly persisted as
    `nil`.
    
    Fixes #18422
    sgrif committed Jan 9, 2015
  13. Merge pull request #18390 from tgxworld/parallel_bundle_install

    Use parallel bundler install.
    rafaelfranca committed Jan 9, 2015
  14. Merge pull request #18413 from brainopia/automatic_inverse_of_for_bel…

    …ongs_to
    
    Correctly count methods when using declarative `#test` in minitest
    dhh committed Jan 9, 2015
  15. Use parallel bundler install.

    tgxworld committed Jan 7, 2015
  16. Merge pull request #18423 from jone/remove-default-header

    Default headers, removed in controller actions, will not be reapplied to the test response
    senny committed Jan 9, 2015
  17. Default headers, removed in controller actions, will not be reapplied…

    … to the test response.
    jone committed Jan 9, 2015
  18. Merge pull request #18416 from caike/master

    Add _mailer suffix to i18n path
    rafaelfranca committed Jan 9, 2015
  19. Merge pull request #18417 from yoshiokatsuneo/active_record_connectio…

    …n_pool_error_disconnect
    
    ActiveRecord: release connection on reconnect failure.
    sgrif committed Jan 9, 2015