Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
SessionCommandStore broken #48
I've only managed to test on Rails 3.2, but it looks like SessionCommandStore has been broken since 9b0833e was introduced. The core problem is the config file is now loaded as a HashWithIndifferentAccess, rather than as a simple hash. HashWithIndifferentAccess ensures any hash values are also types of HashWithIndifferentAccess. In order to do so, it must make a new copy of the value. In this case, the value is the session, which is a hash. Creating a new session with indifferent access creates a new hash that is no longer associated with the session, so all modifications are now on an in-memory copy.
This comment has been minimized.
This comment has been minimized.Show comment Hide comment
I'd be reverting the following commits:
Doesn't look like a problem to do so, seeing as they all involve the same file, and they're the latest commits for that file (all by @indirect).