Include name_tag method if name is passed as a parameter to identify #31

merged 2 commits into from Dec 9, 2011

2 participants


I see there's another pull request for this but I think this is done a bit closer to how you wanted it.

shiftb added some commits Dec 8, 2011
@shiftb shiftb include name_tag method if name is provided as a parameter for mixpan…
…el identity
@shiftb shiftb use full quotes around event and page names when generating track cal…
…ls because the _analytical_javascript regular expression that converts those __EVENT__ and __PAGE__ to parameter names is dependent on double quotes (cant be single quotes)

also fixed the Analytical. js helper for mixpanel. The analytical_javascript partial does a gsub on the EVENT and PAGE params, but requires them to be surrounded by double quotes, not single quotes.

@jkrall jkrall merged commit 4841407 into jkrall:master Dec 9, 2011

Thanks for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment