Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Handle missing module names #37

merged 7 commits into from Jul 31, 2012


None yet
3 participants

indirect commented Jan 27, 2012

This pull request adds a rescue block to the code that loads modules based on the config. If a module doesn't exist, it explains why there is an error, and suggests that you fix your analytical.yml file.

I meant to just fix this to handle missing module names better, but I wound up accidentally rewriting the config file loading code. If you want them as separate pull requests, just let me know.

@jkrall jkrall added a commit that referenced this pull request Jul 31, 2012

@jkrall jkrall Merge pull request #37 from indirect/module_names
Handle missing module names

@jkrall jkrall merged commit 58aa38d into jkrall:master Jul 31, 2012


nirvdrum commented on lib/analytical.rb in 9b0833e Aug 19, 2012

FYI, this line broke the SessionCommandStore. Since this HashWithIndifferentAccess is the base config now and HashWithIndifferentAccess makes copies of any hash value on assignment, assigning @options[:session] to the session actually stores a disassociated, cloned copy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment