Kissmetrics id fallback #54

Merged
merged 3 commits into from Nov 11, 2012

Conversation

Projects
None yet
3 participants
Contributor

oshoma commented Oct 28, 2012

This request allows KissMetrics #identify to fall back to using the id parameter when :email is not provided.

I need the two preceding commits to get tests working and bundle install working.

yachi and others added some commits Oct 22, 2012

@yachi yachi fix tests bd16145
@oshoma oshoma Require rb-fsevent gem version >= v0.9.2
This resolves the following build error. Apparently rb-fsevent 0.4.0 is obsolete.
  Installing rb-fsevent (0.4.0) with native extensions
  Gem::Installer::ExtensionBuildError: ERROR: Failed to build gem native extension.
  …
  extconf.rb:48:in `<main>': Compilation of fsevent_watch failed (see README) (RuntimeError)
e1e6971
@oshoma oshoma Modify KissMetrics #identify to fall back to ID parameter when :email…
… parameter is not present
50a236a

yachi commented on 50a236a Oct 28, 2012

+1

jkrall merged commit b72535c into jkrall:master Nov 11, 2012

Contributor

oshoma commented Nov 11, 2012

Hooray! Thanks for this lovely gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment