Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add Segment.io module #68

Merged
merged 7 commits into from Mar 12, 2013

Conversation

Projects
None yet
2 participants
Contributor

dipth commented Feb 25, 2013

Contributor

dipth commented Mar 6, 2013

@sfsekaran do you have time to also take a look at this one?

Collaborator

sfsekaran commented Mar 6, 2013

Looks straightforward, and passing in Travis-CI. I see no problem merging this, but would you mind adding it to the list of supported libs in the readme (as a link to its site)? I'll merge as soon as that's in.

Contributor

dipth commented Mar 8, 2013

@sfsekaran done :)

dipth added some commits Feb 22, 2013

Add option for dynamic modules
Especially handy in a multi-tenancy setup where each tenant might not want the same modules and keys.
Update README to reflect changes
and selflessly add myself to the list of contributors.

sfsekaran added a commit that referenced this pull request Mar 12, 2013

@sfsekaran sfsekaran merged commit 7ef0a45 into jkrall:master Mar 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment