Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in 4.0.2 #123

Closed
doug1234 opened this issue Feb 16, 2024 · 7 comments
Closed

Crash in 4.0.2 #123

doug1234 opened this issue Feb 16, 2024 · 7 comments
Assignees

Comments

@doug1234
Copy link
Contributor

The function JKQTMathTextFontSpecifier JKQTMathTextFontSpecifier::getAppFontSFFamilies() crashes if it gets called in 4.0.2. This is due to a missing variable definition. Looks like it has been fixed in master. Should there be a 4.0.3?

@jkriege2
Copy link
Owner

Hmmm ... it seems that went pear-shaped ... 4.0.2 seems not to be a tag onto the 4.0.0. branch, but I erroneously tagged the master .... so that function was never meant to be in that tag.

I think I will have to think about starting to tag 5.0.0 version ... I got a lot of the features that I wished for that release by now ...

Until I can create a 5.0.0 branch ... could you work with master?

@jkriege2 jkriege2 self-assigned this Feb 21, 2024
@doug1234
Copy link
Contributor Author

Maybe I should just use the 4.0.1 tag then. Should that one be safe?

@jkriege2
Copy link
Owner

If you don't need this fix: #115 you can use 4.0.1

@jkriege2
Copy link
Owner

BTW: Which part of JKQTPlotter do you use?

@doug1234
Copy link
Contributor Author

I really just use the basic stuff. I don't think that fix is necessary. I could wait for 5.0 to update.

@jkriege2
Copy link
Owner

I just added a release v4.0.3 which should again be on the correct 4.0.0 branch ... does this help (unless you use the more feature-rich 5.0/master anyways)

@doug1234
Copy link
Contributor Author

Thanks. Will start using that version shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants