New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSpec 3 support via guard-rspec-1.x #40

Merged
merged 2 commits into from Feb 6, 2015

Conversation

Projects
None yet
3 participants
@nilbus
Collaborator

nilbus commented Feb 6, 2015

Until #38 is implemented for guard-rspec 5.x / guard 2.x compatibility, we're stuck with guard-rspec < 4.0. guard-rspec 1.x is the only version in this range that does not have a runtime dependency on rspec 2. guard-rspec 2.0.0 introduced a runtime dependency on rspec 2 when it started using RSpec's options parser.

In addition, guard-rspec-2.0.0 changed Guard::RSpec::Formatter from a module to a class. guard-jruby-rspec addressed that change in 5f8ec60 but did not update its gem dependency to exclude guard-rspec < 2.0.0 as a compatible version, nor did it continue to support the old version, where it was a module. I fixed this in 64a04f9, now in master.

My goal is to support both guard-rspec versions 1-3, as the gemspec reports to. Then bundler can resolve guard-rspec 1 + rspec 3 or guard-rspec 2/3 + rspec 2.

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Feb 6, 2015

Collaborator

Tested working with:

  • guard-rspec (1.2.1)
  • guard (1.8.3)
  • rspec (3.1.0)

Test pending with:

  • guard-rspec (3.0.3)
  • guard (1.8.3)
  • rspec (2.13.0)
Collaborator

nilbus commented Feb 6, 2015

Tested working with:

  • guard-rspec (1.2.1)
  • guard (1.8.3)
  • rspec (3.1.0)

Test pending with:

  • guard-rspec (3.0.3)
  • guard (1.8.3)
  • rspec (2.13.0)
@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Feb 6, 2015

Collaborator

Confirmed working with:

  • guard-rspec (3.1.0)
  • guard (1.8.3)
  • rspec (2.13.0)

Merging this into master.

Collaborator

nilbus commented Feb 6, 2015

Confirmed working with:

  • guard-rspec (3.1.0)
  • guard (1.8.3)
  • rspec (2.13.0)

Merging this into master.

nilbus added a commit that referenced this pull request Feb 6, 2015

Merge pull request #40 from jkutner/guard-rspec-1-compat
RSpec 3 support via guard-rspec-1.x

@nilbus nilbus merged commit b7c861d into master Feb 6, 2015

@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Feb 7, 2015

Collaborator

@jkutner I prepped a 0.2.2 release. Would you like to review and do a new tag and rubygems release?

Collaborator

nilbus commented Feb 7, 2015

@jkutner I prepped a 0.2.2 release. Would you like to review and do a new tag and rubygems release?

@nilbus nilbus deleted the guard-rspec-1-compat branch Feb 7, 2015

@jkutner

This comment has been minimized.

Show comment
Hide comment
@jkutner

jkutner Feb 7, 2015

Owner

Will do!

On Fri, Feb 6, 2015 at 6:09 PM, Edward Anderson notifications@github.com
wrote:

@jkutner I prepped a 0.2.2 release. Would you like to review and do a new tag and rubygems release?

Reply to this email directly or view it on GitHub:
#40 (comment)

Owner

jkutner commented Feb 7, 2015

Will do!

On Fri, Feb 6, 2015 at 6:09 PM, Edward Anderson notifications@github.com
wrote:

@jkutner I prepped a 0.2.2 release. Would you like to review and do a new tag and rubygems release?

Reply to this email directly or view it on GitHub:
#40 (comment)

@swistaczek

This comment has been minimized.

Show comment
Hide comment
@swistaczek

swistaczek Feb 10, 2015

Great work @nilbus! @jkutner could you please push update to rubygems :)?

swistaczek commented Feb 10, 2015

Great work @nilbus! @jkutner could you please push update to rubygems :)?

@jkutner

This comment has been minimized.

Show comment
Hide comment
@swistaczek

This comment has been minimized.

Show comment
Hide comment
@swistaczek

swistaczek Feb 11, 2015

Thanks you very much @jkutner 😄.

swistaczek commented Feb 11, 2015

Thanks you very much @jkutner 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment