Conversation
Collaborator
Author
|
Tested working with:
Test pending with:
|
Collaborator
Author
|
Confirmed working with:
Merging this into master. |
nilbus
added a commit
that referenced
this pull request
Feb 6, 2015
RSpec 3 support via guard-rspec-1.x
Collaborator
Author
|
@jkutner I prepped a 0.2.2 release. Would you like to review and do a new tag and rubygems release? |
Owner
|
Will do! On Fri, Feb 6, 2015 at 6:09 PM, Edward Anderson notifications@github.com
|
Owner
|
Thanks you very much @jkutner 😄. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until #38 is implemented for guard-rspec 5.x / guard 2.x compatibility, we're stuck with guard-rspec < 4.0. guard-rspec 1.x is the only version in this range that does not have a runtime dependency on rspec 2. guard-rspec 2.0.0 introduced a runtime dependency on rspec 2 when it started using RSpec's options parser.
In addition, guard-rspec-2.0.0 changed
Guard::RSpec::Formatterfrom a module to a class. guard-jruby-rspec addressed that change in 5f8ec60 but did not update its gem dependency to exclude guard-rspec < 2.0.0 as a compatible version, nor did it continue to support the old version, where it was a module. I fixed this in 64a04f9, now in master.My goal is to support both guard-rspec versions 1-3, as the gemspec reports to. Then bundler can resolve guard-rspec 1 + rspec 3 or guard-rspec 2/3 + rspec 2.