Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please migrate QtScript usage to QJSEngine (support will be removed in Qt 5.6) #44

Closed
pete-woods opened this Issue Aug 12, 2015 · 14 comments

Comments

Projects
None yet
2 participants
@pete-woods
Copy link

pete-woods commented Aug 12, 2015

QtScript is currently deprecated, and in Qt 5.6 it will be removed.

I currently use QDjango for one of the components in Ubuntu Touch (the infographics on the lock screen). See (https://bugs.launchpad.net/ubuntu/+source/libusermetrics/+bug/1457488).

Apparently the replacement for QtScript is QJSEngine (http://doc.qt.io/qt-5/qtjavascript.html).

Thanks!

@jlaine

This comment has been minimized.

Copy link
Owner

jlaine commented Aug 12, 2015

Hi Pete,

Thanks for bringing this up. I am wondering whether a new qdjango-js library as a replacement for qdjango-script might be the right way to go?

@pete-woods

This comment has been minimized.

Copy link
Author

pete-woods commented Aug 12, 2015

Sounds reasonable to me. If you make the qdjango-script library an optional build component, then we can just disable it when QtScript stops being available.

@jlaine

This comment has been minimized.

Copy link
Owner

jlaine commented Aug 12, 2015

Do you have any feedback on the current QtScript-based API so we can make the QJSEngine-based one better? Can you point me to the code where you make use of the QtScript bindings?

@pete-woods

This comment has been minimized.

Copy link
Author

pete-woods commented Aug 12, 2015

Unfortunately not. I don't actually use it.

In reality I could get away just with the library build being optional, and then not building it in Ubuntu when 5.6 is released.

@pete-woods

This comment has been minimized.

Copy link
Author

pete-woods commented Aug 12, 2015

Updated my first comment where I mistakenly said I used qdjangoscript, rather than just qdjango.

@jlaine

This comment has been minimized.

Copy link
Owner

jlaine commented Aug 12, 2015

Ah OK, in that case I would be in favor of simply disabling QtScript support when building against Qt5

@pete-woods

This comment has been minimized.

Copy link
Author

pete-woods commented Aug 12, 2015

Or at least Qt >= 5.6

@pete-woods

This comment has been minimized.

Copy link
Author

pete-woods commented Aug 12, 2015

If I knew QMake, I'd already have a pull request for you, but sadly I'm only familiar with CMake.

@pete-woods

This comment has been minimized.

Copy link
Author

pete-woods commented Aug 12, 2015

Something like that?

@jlaine

This comment has been minimized.

Copy link
Owner

jlaine commented Aug 12, 2015

Pete, I have given it some thought and I am going to simply pull qdjango-script:

  • This code is not on par with the rest of QDjango quality-wise
  • I have never received any questions, issues or any sort of feedback about it
  • I do not believe there is a valid case for using it.
  • QtScript being dropped is a strong signal that this technology is obsolete.

@jlaine jlaine closed this in 725f381 Aug 12, 2015

@pete-woods

This comment has been minimized.

Copy link
Author

pete-woods commented Aug 12, 2015

Okay, sounds good to me. Just need a release of 0.6.0 now :)

@pete-woods

This comment has been minimized.

Copy link
Author

pete-woods commented Aug 12, 2015

Oh cool, you already did it! Now to upload it to the Ubuntu archive.

@jlaine

This comment has been minimized.

Copy link
Owner

jlaine commented Aug 12, 2015

Can we coordinate on that please? I am in the process of moving Debian's packaging to git in collab-maint and would like for us to take the chance to resync Ubuntu/Debian packaging.

@pete-woods

This comment has been minimized.

Copy link
Author

pete-woods commented Aug 13, 2015

I think I will just wait for you to upload to Debian when you feel it's appropriate. Then we can merge the changes into Ubuntu when that happens. FYI, the only packaging difference between the two is that we build with Qt 5 by default on Ubuntu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.