Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse files

(No bug): Add comments to some debugger server code. r=past in IRC

  • Loading branch information...
commit 4d6166fbfaa1f7fb6e11eb39466f65889b7ec891 1 parent 0b0bc87
Jim Blandy authored
View
3  toolkit/devtools/debugger/server/dbg-browser-actors.js
@@ -196,6 +196,9 @@ BrowserRootActor.prototype = {
onWindowTitleChange: function BRA_onWindowTitleChange(aWindow, aTitle) { },
onOpenWindow: function BRA_onOpenWindow(aWindow) { },
onCloseWindow: function BRA_onCloseWindow(aWindow) {
+ // An nsIWindowMediatorListener's onCloseWindow method gets passed all
+ // sorts of windows; we only care about the tab containers. Those have
+ // 'getBrowser' methods.
if (aWindow.getBrowser) {
this.unwatchWindow(aWindow);
}
View
3  toolkit/devtools/debugger/server/dbg-script-actors.js
@@ -133,6 +133,9 @@ ThreadActor.prototype = {
this._threadLifetimePool = null;
this.conn.removeActorPool(this._breakpointPool);
this._breakpointPool = null;
+ // Unless we carefully take apart the scripts table this way, we end up
+ // leaking documents. It would be nice to track this down carefully, once
+ // we have the appropriate tools.
for (let url in this._scripts) {
delete this._scripts[url];
}
Please sign in to comment.
Something went wrong with that request. Please try again.