-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger input event after updating textarea #87
Trigger input event after updating textarea #87
Conversation
Hmm, testing in a GitHub textbox, this doesn't really seem to fix it for me. On what website did you test this? |
I have tested this on https://tiddlywiki.com:
|
But here it works also in the GitHub comment textbox. |
In case there are different ways of testing: |
The GitHub issue mentioned in #60 is slightly different. Starting Textern on a blank textarea and saving some text doesn't enable the "Comment" button until additional edits are made. Ideally we have something that fixes that too. In some quick tests, I played around with variations of that code and e.g. |
Oh, yes, you are right about the "Comment" button. So far, I couldn't find a way to enable it. But you could merge this anyway as it fixes my issue in TiddlyWiki. (And maybe for other web pages, too.) |
WFM. Can you add a short comment explaining the line, and drop the fixes marker for #60? |
4e3a59e
to
0f5f7c7
Compare
No problem. Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch!
Trigger input event after updating a textarea with textern to make website aware of changed text. This is necessary on https://tiddlywiki.com.