Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add titleColor & taglineColor options #2

Merged
merged 6 commits into from Jan 16, 2020

Conversation

@horacioh
Copy link
Contributor

horacioh commented Jan 8, 2020

add new titleColor and taglineColor to specify text color separately.

some notes about it:

  • they do not have default values, since textColor will be the default.
  • they are optional, and follow the same format as textColor.

example: https://res.cloudinary.com/horacioh/image/upload/w_1280,h_669,c_fill,q_auto,f_auto/w_760,c_fit,co_rgb:A6E22E,g_south_west,x_480,y_254,l_text:verb-black.otf_56:Aprende%20GatsbyJS%20en%20espa%C3%B1ol%20GRATIS!/w_760,c_fit,co_rgb:66D9EF,g_north_west,x_480,y_445,l_text:verb-medium.otf_36:%23spanish%20%23tutorial/horacioh.com/post-card.jpg

post-card

fix #1

horacioh added 2 commits Jan 8, 2020
Copy link
Owner

jlengstorf left a comment

great work! it looks like this branch is a bit out of sync with master, but I think it'll be pretty quick to rebase so we can get this in

thanks so much!

README.md Outdated
| cloudinaryUrlBase | | (string, default `https://res.cloudinary.com`) Cloudinary asset URL |
| titleFont | | (string, default `arial`) font to use for rendering title |
| titleExtraConfig | | (string) optional additional text overlay config |
| taglineExtraConfig | | (string) optional additional text overlay config |

This comment has been minimized.

Copy link
@jlengstorf

jlengstorf Jan 8, 2020

Owner

it looks like we lost some changes here — can you rebase your branch against master to make sure all the latest updates are included?

This comment has been minimized.

Copy link
@horacioh

horacioh Jan 15, 2020

Author Contributor

I think i got all the changes right now :)

horacioh and others added 4 commits Jan 15, 2020
Copy link
Owner

jlengstorf left a comment

looks good!

@jlengstorf jlengstorf merged commit 7019fef into jlengstorf:master Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.