New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace tip #3

Closed
wesleycoder opened this Issue Sep 12, 2016 · 1 comment

Comments

2 participants
@wesleycoder

wesleycoder commented Sep 12, 2016

Dunno if this is the right place to this, but...

I have struggled with rollup-plugin-replace for half an hour about it being breaking stuff when I put react in my project when reading/watching https://code.lengstorf.com/learn-rollup-js/

The thing is that by default replace will transform node_modules modules too and in order to avoid it we have to add node_modules/** to the exclude option passed to replace.

You could put a tip in your article in order to help others not being trapped in this situation.

Ty 4 the awesome content.

@jlengstorf

This comment has been minimized.

Owner

jlengstorf commented Sep 12, 2016

I added a note in jlengstorf/code.lengstorf.com@688e3d7.

Thanks for the heads-up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment