2012 updates #24

Merged
merged 10 commits into from May 2, 2012

Conversation

Projects
None yet
3 participants
Contributor

peterlynch commented Apr 30, 2012

Includes:

  • branding generification ( make Hudson, Jenkins, Sonatype Hudson Pro friendly)
  • pom cleanup to avoid spewing errors everywhere when building
  • depend on latest jenkins-ci stable parent, includes commented option for configuring with 2.0.0 hudson parent for comparison purposes
  • clarify purpose of lone test
  • code formatting cleanup
  • FEATURE: "Send As" global feature to allow specifying who hipchat messages are sent as
  • FEATURE: Project specific notification filtering - allow projects to choose which types of notifications are sent per project

peterlynch added some commits Apr 26, 2012

clean up help and code to not be so Jenkins specific
Consider that one may run this plugin in Hudson/Jenkins/or even Sonatype Hudson Pro

Also some better wording in spots not branding related.
Add global 'send as' option
Configure at global level the name of the hip chat user to send notifications as.

Useful to not use "Jenkins" as may be running this plugin in Hudson, Jenkins, or something else - or would rather just send messages as "Evil Build Server".
Add support for project level notification filtering on build result
Each project can choose when notifications get sent based on the result of the build.
cleanup pom to eliminate build warnings and remove unused cruft
disabled inject test bits in hpi plugin to avoid a bunch of crap output that has no relevance to this plugin

added mention of hudson parent in case someone would like to compare building this against hudson sources.

- added parent for latest jenkins-ci stable version
delete this test - it is useless as is
just borks by default anyways and spews error to console

Exceptions thrown when a message couldn't be sent to hipchat were failing builds. This test ensured that exceptions weren't bubbling up...although it didn't express the intent as well as it could have.

Contributor

peterlynch commented May 2, 2012

Just wondering if @jlewallen is still managing these pulls here - noticed the other pull dormant for a month.

jlewallen added a commit that referenced this pull request May 2, 2012

@jlewallen jlewallen merged commit ae4fa4e into jlewallen:master May 2, 2012

Owner

jlewallen commented May 2, 2012

yeah, i'm still around... sorry i don't get much time to devote to this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment