Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from nologin to manual to fix issue #13 #14

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion lib.php
Expand Up @@ -28,6 +28,10 @@


use moodle\local\ltiprovider as ltiprovider; use moodle\local\ltiprovider as ltiprovider;


/**
* Auth type since nologin sessions are destroyed during session_gc
*/
define('LTIPROVIDER_AUTH_TYPE', 'manual');


/** /**
* Function for backwards compatibility (<2.4) * Function for backwards compatibility (<2.4)
Expand Down Expand Up @@ -60,7 +64,7 @@ function local_ltiprovider_extends_navigation ($nav) {
$coursenode->add(get_string('pluginname', 'local_ltiprovider'), $ltiurl, $nav::TYPE_CONTAINER, null, 'ltiprovider'.$PAGE->course->id); $coursenode->add(get_string('pluginname', 'local_ltiprovider'), $ltiurl, $nav::TYPE_CONTAINER, null, 'ltiprovider'.$PAGE->course->id);
} }


if (isset($USER) and isset($USER->auth) and $USER->auth == 'nologin' and strpos($USER->username, 'ltiprovider') === 0) { if (isset($USER) and isset($USER->auth) and $USER->auth == LTIPROVIDER_AUTH_TYPE and strpos($USER->username, 'ltiprovider') === 0) {
// Force course or activity navigation // Force course or activity navigation
if (isset($SESSION->ltiprovider) and $SESSION->ltiprovider->forcenavigation) { if (isset($SESSION->ltiprovider) and $SESSION->ltiprovider->forcenavigation) {
$context = $SESSION->ltiprovider->context; $context = $SESSION->ltiprovider->context;
Expand Down
3 changes: 2 additions & 1 deletion tool.php
Expand Up @@ -25,6 +25,7 @@


require_once(dirname(__FILE__) . '/../../config.php'); require_once(dirname(__FILE__) . '/../../config.php');
require_once($CFG->dirroot.'/local/ltiprovider/ims-blti/blti.php'); require_once($CFG->dirroot.'/local/ltiprovider/ims-blti/blti.php');
require_once($CFG->dirroot.'/local/ltiprovider/lib.php');


$toolid = required_param('id', PARAM_INT); $toolid = required_param('id', PARAM_INT);


Expand Down Expand Up @@ -118,7 +119,7 @@ function user_match($newuser, $olduser) {
if (! $dbuser ) { if (! $dbuser ) {
$user = new stdClass(); $user = new stdClass();
// clean_param , email username text // clean_param , email username text
$user->auth = 'nologin'; $user->auth = LTIPROVIDER_AUTH_TYPE;
$user->username = $username; $user->username = $username;
$user->password = md5(uniqid(rand(), 1)); $user->password = md5(uniqid(rand(), 1));
populate($user,$context,$tool); populate($user,$context,$tool);
Expand Down