From ede9c74d50369bc2ce80aabb5f820a14f0d38d44 Mon Sep 17 00:00:00 2001 From: Jamie Wong Date: Tue, 29 Sep 2020 16:20:27 -0700 Subject: [PATCH] Remove accidentally added/retained dependencies on react and react-redux (#315) speedscope no longer relies upon react-redux, and never depended upon react. Let's clean these up. --- package-lock.json | 73 ++++------------------------------------ package.json | 4 +-- src/lib/preact-redux.tsx | 2 +- 3 files changed, 9 insertions(+), 70 deletions(-) diff --git a/package-lock.json b/package-lock.json index 21fe93a2b..69ccfbed7 100644 --- a/package-lock.json +++ b/package-lock.json @@ -5793,15 +5793,6 @@ "minimalistic-crypto-utils": "^1.0.1" } }, - "hoist-non-react-statics": { - "version": "3.3.2", - "resolved": "https://registry.npmjs.org/hoist-non-react-statics/-/hoist-non-react-statics-3.3.2.tgz", - "integrity": "sha512-/gGivxi8JPKWNm/W0jSmzcMPpfpPLc3dY/6GxhX2hQ9iGj3aDfklV4ET7NjKpSinLpJ5vafa9iiGIEZg10SfBw==", - "dev": true, - "requires": { - "react-is": "^16.7.0" - } - }, "hosted-git-info": { "version": "2.8.5", "resolved": "https://registry.npmjs.org/hosted-git-info/-/hosted-git-info-2.8.5.tgz", @@ -7082,7 +7073,8 @@ "js-tokens": { "version": "3.0.2", "resolved": "https://registry.npmjs.org/js-tokens/-/js-tokens-3.0.2.tgz", - "integrity": "sha1-mGbfOVECEw449/mWvOtlRDIJwls=" + "integrity": "sha1-mGbfOVECEw449/mWvOtlRDIJwls=", + "dev": true }, "js-yaml": { "version": "3.13.1", @@ -7426,6 +7418,7 @@ "version": "1.3.1", "resolved": "https://registry.npmjs.org/loose-envify/-/loose-envify-1.3.1.tgz", "integrity": "sha1-0aitM/qc4OcT1l/dCsi3SNR4yEg=", + "dev": true, "requires": { "js-tokens": "^3.0.0" } @@ -7891,7 +7884,8 @@ "object-assign": { "version": "4.1.1", "resolved": "https://registry.npmjs.org/object-assign/-/object-assign-4.1.1.tgz", - "integrity": "sha1-IQmtx5ZYh8/AXLvUQsrIv7s2CGM=" + "integrity": "sha1-IQmtx5ZYh8/AXLvUQsrIv7s2CGM=", + "dev": true }, "object-copy": { "version": "0.1.0", @@ -9270,26 +9264,6 @@ "sisteransi": "^1.0.3" } }, - "prop-types": { - "version": "15.7.2", - "resolved": "https://registry.npmjs.org/prop-types/-/prop-types-15.7.2.tgz", - "integrity": "sha512-8QQikdH7//R2vurIJSutZ1smHYTcLpRWEOlHnzcWHmBYrOGUysKwSsrC89BCiFj3CbrfJ/nXFdJepOVrY1GCHQ==", - "requires": { - "loose-envify": "^1.4.0", - "object-assign": "^4.1.1", - "react-is": "^16.8.1" - }, - "dependencies": { - "loose-envify": { - "version": "1.4.0", - "resolved": "https://registry.npmjs.org/loose-envify/-/loose-envify-1.4.0.tgz", - "integrity": "sha512-lyuxPGr/Wfhrlem2CL/UcnUc1zcqKAImBDzukY7Y5F/yQiNdko6+fRLevlw1HgMySw7f611UIY408EtxRSoK3Q==", - "requires": { - "js-tokens": "^3.0.0 || ^4.0.0" - } - } - } - }, "protobufjs": { "version": "6.8.8", "resolved": "https://registry.npmjs.org/protobufjs/-/protobufjs-6.8.8.tgz", @@ -9538,44 +9512,11 @@ "integrity": "sha1-CMbgSgFo9utiHCKrbLEVG9n0pk0=", "dev": true }, - "react": { - "version": "16.13.1", - "resolved": "https://registry.npmjs.org/react/-/react-16.13.1.tgz", - "integrity": "sha512-YMZQQq32xHLX0bz5Mnibv1/LHb3Sqzngu7xstSM+vrkE5Kzr9xE0yMByK5kMoTK30YVJE61WfbxIFFvfeDKT1w==", - "requires": { - "loose-envify": "^1.1.0", - "object-assign": "^4.1.1", - "prop-types": "^15.6.2" - } - }, "react-is": { "version": "16.12.0", "resolved": "https://registry.npmjs.org/react-is/-/react-is-16.12.0.tgz", - "integrity": "sha512-rPCkf/mWBtKc97aLL9/txD8DZdemK0vkA3JMLShjlJB3Pj3s+lpf1KaBzMfQrAmhMQB0n1cU/SUGgKKBCe837Q==" - }, - "react-redux": { - "version": "7.2.0", - "resolved": "https://registry.npmjs.org/react-redux/-/react-redux-7.2.0.tgz", - "integrity": "sha512-EvCAZYGfOLqwV7gh849xy9/pt55rJXPwmYvI4lilPM5rUT/1NxuuN59ipdBksRVSvz0KInbPnp4IfoXJXCqiDA==", - "dev": true, - "requires": { - "@babel/runtime": "^7.5.5", - "hoist-non-react-statics": "^3.3.0", - "loose-envify": "^1.4.0", - "prop-types": "^15.7.2", - "react-is": "^16.9.0" - }, - "dependencies": { - "loose-envify": { - "version": "1.4.0", - "resolved": "https://registry.npmjs.org/loose-envify/-/loose-envify-1.4.0.tgz", - "integrity": "sha512-lyuxPGr/Wfhrlem2CL/UcnUc1zcqKAImBDzukY7Y5F/yQiNdko6+fRLevlw1HgMySw7f611UIY408EtxRSoK3Q==", - "dev": true, - "requires": { - "js-tokens": "^3.0.0 || ^4.0.0" - } - } - } + "integrity": "sha512-rPCkf/mWBtKc97aLL9/txD8DZdemK0vkA3JMLShjlJB3Pj3s+lpf1KaBzMfQrAmhMQB0n1cU/SUGgKKBCe837Q==", + "dev": true }, "read-pkg": { "version": "3.0.0", diff --git a/package.json b/package.json index 262d18ac3..add96fc9b 100644 --- a/package.json +++ b/package.json @@ -50,7 +50,6 @@ "preact": "10.4.1", "prettier": "2.0.4", "protobufjs": "6.8.8", - "react-redux": "^7.2.0", "redux": "^4.0.5", "ts-jest": "24.3.0", "typescript": "3.9.2", @@ -79,7 +78,6 @@ ] }, "dependencies": { - "open": "7.2.0", - "react": "^16.13.1" + "open": "7.2.0" } } diff --git a/src/lib/preact-redux.tsx b/src/lib/preact-redux.tsx index c9ff77cc5..34eedc5c0 100644 --- a/src/lib/preact-redux.tsx +++ b/src/lib/preact-redux.tsx @@ -1,7 +1,7 @@ /** * As of Preact 10.x, they no longer have an officially supported preact-redux library. * It's possible to use react-redux with some hacks, but these hacks cause npm run pack - * to error out because of (intentinoally) unmet peer dependencies. + * to error out because of (intentionally) unmet peer dependencies. * * I could stack more hacks to fix this problem, but I'd rather just drop the dependency * and remove the need to do any dependency hacking by writing the very small part of