New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not ellipsize file name #191
Comments
Hi @yajo! I've heard this feedback from a few people now, and I think at least one version of it should be pretty easy to fix. The relevant code to fix this is here: speedscope/src/views/hovertip.tsx Line 11 in ad49dac
I'd accept a PR to make the tooltip extend to the edge of the container with a margin |
Hi, is enough to only increase TOOLTIP_WIDTH_MAX to 900? |
@miso11 Sure, I'd accept a PR to do that, assuming it never overflows the window (which I don't think it should) |
Issue #191 It shouldn't be ellipsized, or at least it should be to the right, because I think it's more interesting the file name and function name than the system path where it is found. Make max width bigger Before: ![before](https://user-images.githubusercontent.com/52132927/67621727-ff6dda80-f812-11e9-8c10-533542fe0302.png) After: ![after](https://user-images.githubusercontent.com/52132927/67621730-04cb2500-f813-11e9-8d36-80e8c58a529e.png)
I'll close this for now due to #239, though I'd also be happy to take a more complete PR that does ellipsization in the middle of the string rather than the end |
When hovering over calls, the file & method is ellipsized to the left, which is useless in my case (and I imagine also for others):
It shouldn't be ellipsized, or at least it should be to the right, because I think it's more interesting the file name and function name than the system path where it is found.
The text was updated successfully, but these errors were encountered: