Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Import v8 cpu profile (old format) #177
I'm afraid I don't think I agree on either of these fronts. We can certainly discuss, but at a minimum I'd like these to be part of a different PR, since they affect more than what's described in this PR description, and I'd like to avoid interleaving comments about that change with comments about the correctness of the old format import.
referenced this pull request
Oct 10, 2018
Thanks for another significant contribution!
In addition to the inline comments below, I have a request for the example profile.
Before this PR,
chrome.test.ts.snap is 521 lines (https://github.com/jlfwong/speedscope/blob/master/src/import/__snapshots__/chrome.test.ts.snap), and after this PR with the current example profile, it's 24000 lines.