New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chrome: do not merge gc/program frame + show idle frame #176 #178

Open
wants to merge 2 commits into
base: master
from

Conversation

2 participants
@vmarchaud
Contributor

vmarchaud commented Oct 10, 2018

As discused in #177, i'm making a new PR for this change (sorry for not doing it directly, i was in rush to finish before leaving work)
Some arguments for the why :

As discussed in #176, i believe speedscope need to show what's happening in the main thread at any given time, both of the gc and program frame represent blocking operation, so they should be shown at the top level so user can understand that their code isn't running while they are.
Note that program is actually native code, either V8 or any C++ binding :
Source : https://trac.webkit.org/changeset/138004/webkit

vmarchaud added some commits Oct 9, 2018

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 10, 2018

Coverage Status

Coverage decreased (-0.1%) to 44.356% when pulling 4693494 on vmarchaud:vmarchaud/v8-profile-native-frames into 0fe0c45 on jlfwong:master.

coveralls commented Oct 10, 2018

Coverage Status

Coverage decreased (-0.1%) to 44.356% when pulling 4693494 on vmarchaud:vmarchaud/v8-profile-native-frames into 0fe0c45 on jlfwong:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment