New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use homebrew tap instead of forking homebrew #1

Merged
merged 4 commits into from Dec 16, 2013

Conversation

Projects
None yet
2 participants
@nilbus

nilbus commented Dec 2, 2013

The standard way to add formula to homebrew is to have a repository named homebrew-formulaName that contains only the formula. These can be used easily by any homebrew user without having to go through the hassle of modifying their homebrew repository to use your fork.

See the added README.md for the usage instructions with brew tap.

Tested against nilbus/homebrew-lsusb and working.

jlhonora and others added some commits Oct 30, 2013

Corrected multiple homebrew errors
Corrected the following errors with previous pull request
commit. All pointed by 'adamv':

  * Fixed `brew audit` suggestions
  * Added a tarball instead of specific commits
  * No parentheses in calls, 'ala ruby'
  * Removed test
New formula: lsusb - updated to v0.2
Main branch was updated with better style and practices,
script runs faster. Also improved the man page. All this thanks to
@paulp's suggestions.
Allow using brew tap instead requiring users to clone a fork
Move lsusb.rb formula to /.
Remove homebrew code.
@nilbus

This comment has been minimized.

Show comment
Hide comment
@nilbus

nilbus Dec 2, 2013

This PR also includes the commits from your tap branch, which I found to be good and working.

nilbus commented Dec 2, 2013

This PR also includes the commits from your tap branch, which I found to be good and working.

@jlhonora

This comment has been minimized.

Show comment
Hide comment
@jlhonora

jlhonora Dec 3, 2013

Owner

Thanks a lot for your work, it looks great.

I'll be back from vacation on December 16th, I'll review and (most probably) merge it by then.

Owner

jlhonora commented Dec 3, 2013

Thanks a lot for your work, it looks great.

I'll be back from vacation on December 16th, I'll review and (most probably) merge it by then.

jlhonora added a commit that referenced this pull request Dec 16, 2013

Merge pull request #1 from nilbus/tap
Use homebrew tap instead of forking homebrew

@jlhonora jlhonora merged commit 7367342 into jlhonora:master Dec 16, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment