Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use homebrew tap instead of forking homebrew #1

Merged
merged 4 commits into from Dec 16, 2013
Merged

Conversation

@nilbus
Copy link

nilbus commented Dec 2, 2013

The standard way to add formula to homebrew is to have a repository named homebrew-formulaName that contains only the formula. These can be used easily by any homebrew user without having to go through the hassle of modifying their homebrew repository to use your fork.

See the added README.md for the usage instructions with brew tap.

Tested against nilbus/homebrew-lsusb and working.

jlhonora and others added 4 commits Oct 30, 2013
Corrected the following errors with previous pull request
commit. All pointed by 'adamv':

  * Fixed `brew audit` suggestions
  * Added a tarball instead of specific commits
  * No parentheses in calls, 'ala ruby'
  * Removed test
Main branch was updated with better style and practices,
script runs faster. Also improved the man page. All this thanks to
@paulp's suggestions.
Move lsusb.rb formula to /.
Remove homebrew code.
@nilbus
Copy link
Author

nilbus commented Dec 2, 2013

This PR also includes the commits from your tap branch, which I found to be good and working.

@jlhonora
Copy link
Owner

jlhonora commented Dec 3, 2013

Thanks a lot for your work, it looks great.

I'll be back from vacation on December 16th, I'll review and (most probably) merge it by then.

jlhonora added a commit that referenced this pull request Dec 16, 2013
Use homebrew tap instead of forking homebrew
@jlhonora jlhonora merged commit 7367342 into jlhonora:master Dec 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.