Use homebrew tap instead of forking homebrew #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrected the following errors with previous pull request commit. All pointed by 'adamv': * Fixed `brew audit` suggestions * Added a tarball instead of specific commits * No parentheses in calls, 'ala ruby' * Removed test
Main branch was updated with better style and practices, script runs faster. Also improved the man page. All this thanks to @paulp's suggestions.
Move lsusb.rb formula to /. Remove homebrew code.
|
This PR also includes the commits from your tap branch, which I found to be good and working. |
|
Thanks a lot for your work, it looks great. I'll be back from vacation on December 16th, I'll review and (most probably) merge it by then. |
jlhonora
added a commit
that referenced
this pull request
Dec 16, 2013
Use homebrew tap instead of forking homebrew
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard way to add formula to homebrew is to have a repository named homebrew-formulaName that contains only the formula. These can be used easily by any homebrew user without having to go through the hassle of modifying their homebrew repository to use your fork.
See the added README.md for the usage instructions with
brew tap.Tested against nilbus/homebrew-lsusb and working.