Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Drop use of ThreadLocal, which causes class loader leaks. #98

Merged
merged 1 commit into from May 30, 2014

Conversation

Projects
None yet
3 participants
Contributor

harrah commented Jul 17, 2013

This reverts the main part of 0c6089b. The reason for using a ThreadLocal isn't given in the original commit. The terminal is a global resource and the use of ThreadLocal causes class loader leaks, so this pull request removes the ThreadLocal.

Member

trptcolin commented May 11, 2014

@jdillon any recollection of the reason for the move to ThreadLocal in 0c6089b, or a downside to this PR? I'm inclined to merge this if not.

Owner

jdillon commented May 11, 2014

@trptcolin sorry I don't remember the specifics why this change was made, though I probably had a reason, though since I can't remember the reason I can't say if it was a good one or not :-P

@trptcolin trptcolin merged commit 6a1b6bf into jline:master May 30, 2014

Member

trptcolin commented May 30, 2014

Thanks!

@scabug scabug referenced this pull request in scala/bug Apr 7, 2017

Closed

jline ThreadLocal class loader leak #7673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment