Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JRE dependent "whitespace" generation #55

Closed
tmohme opened this issue Apr 11, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@tmohme
Copy link
Contributor

commented Apr 11, 2019

Testing Problem

Unfortunately what is considered as whitespace character (Character.isWhitespace(...)) has changed between Java 8 (OpenJDK) and Java 11 (OpenJDK):
In particular the U+180E (Mongolian Vovel Separator) counts in Java 8 as whitespace, while it does not in Java 11.

This causes problems because when generating whitespace chars with jqwik (which contains hard-coded lists of whitespace chars based on Java 8) and actually running the functionality on Java 11.

Suggested Solution

Instead of using a prepared, hard-coded list of whitespace chars, the chars considered as whitespace by the actual runtime should be used.
Please have a look at my corresponding pull request.

Discussion

To minimize the runtime overhead, the determination of the whitespace chars could (should) be done at class-level instead of instance-level.

@jlink

This comment has been minimized.

Copy link
Owner

commented Apr 16, 2019

Implemented with 64cfac0

@jlink jlink removed the in progress label Apr 16, 2019

@jlink

This comment has been minimized.

Copy link
Owner

commented Apr 16, 2019

Available in 1.1.3-SNAPSHOT

@jlink jlink closed this Apr 16, 2019

@jlink

This comment has been minimized.

Copy link
Owner

commented Apr 27, 2019

Released in 1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.