Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unshrinkable null value equals And hashCode error #66

Merged
merged 1 commit into from Jul 24, 2019
Merged

Fix Unshrinkable null value equals And hashCode error #66

merged 1 commit into from Jul 24, 2019

Conversation

@mhyeon-lee
Copy link
Contributor

@mhyeon-lee mhyeon-lee commented Jul 24, 2019

Overview

  • Unshrinkable null value got exception when call equals or hashCode method

Details

  • Fix equals and hashCode method to escape NPE.

I hereby agree to the terms of the jqwik Contributor Agreement.

@jlink
Copy link
Owner

@jlink jlink commented Jul 24, 2019

Thanks for the catch! Very valuable. I have two minor change requests. See there...

Loading

package net.jqwik.engine.properties.shrinking;

import net.jqwik.api.Arbitraries;
import net.jqwik.api.Example;
Copy link
Owner

@jlink jlink Jul 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jqwik coding style is to use only wildcard imports, e.g. import net.jqwik.api.*

Loading

Loading
@jlink jlink merged commit 221d9bd into jlink:master Jul 24, 2019
1 check passed
Loading
@jlink
Copy link
Owner

@jlink jlink commented Jul 24, 2019

Thanks again. Welcome to jqwik's list of contributors.

Loading

@jlink
Copy link
Owner

@jlink jlink commented Jul 24, 2019

Available in 1.2.0-SNAPSHOT

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants