Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Unshrinkable null value equals And hashCode error #66

Merged
merged 1 commit into from Jul 24, 2019

Conversation

@mhyeon-lee
Copy link
Contributor

commented Jul 24, 2019

Overview

  • Unshrinkable null value got exception when call equals or hashCode method

Details

  • Fix equals and hashCode method to escape NPE.

I hereby agree to the terms of the jqwik Contributor Agreement.

@jlink

This comment has been minimized.

Copy link
Owner

commented Jul 24, 2019

Thanks for the catch! Very valuable. I have two minor change requests. See there...

package net.jqwik.engine.properties.shrinking;

import net.jqwik.api.Arbitraries;
import net.jqwik.api.Example;

This comment has been minimized.

Copy link
@jlink

jlink Jul 24, 2019

Owner

jqwik coding style is to use only wildcard imports, e.g. import net.jqwik.api.*

Show resolved Hide resolved ...c/test/java/net/jqwik/engine/properties/shrinking/UnshrinkableTests.java Outdated

@mhyeon-lee mhyeon-lee force-pushed the mhyeon-lee:fix-unshrinkable-null-value-error branch from b77e38d to 78347c9 Jul 24, 2019

@jlink jlink merged commit 221d9bd into jlink:master Jul 24, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jlink

This comment has been minimized.

Copy link
Owner

commented Jul 24, 2019

Thanks again. Welcome to jqwik's list of contributors.

@jlink

This comment has been minimized.

Copy link
Owner

commented Jul 24, 2019

Available in 1.2.0-SNAPSHOT

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.