Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor HID descriptor issue #38

Closed
abend0c1 opened this issue Jan 23, 2018 · 1 comment
Closed

Minor HID descriptor issue #38

abend0c1 opened this issue Jan 23, 2018 · 1 comment
Labels

Comments

@abend0c1
Copy link

@abend0c1 abend0c1 commented Jan 23, 2018

In HID-Wiimote/HID Wiimote/HIDDescriptors.c I think the following:

0x65, 0x12, // UNIT (SI Rot:Angular Pos)

...should be:

0x65, 0x14, // UNIT (English Rot:Angular Pos in Degrees)

...given that the logical values that the usage can have is 1 to 8, and the corresponding physical values are 0 to 315 in 45 degree increments i.e. physical = (logical - 1) * 45

The SI rotational unit is radians not degrees. Probably doesn't matter much...just sayin' :)

@jloehr jloehr added the Driver label Jan 23, 2018
@jloehr
Copy link
Owner

@jloehr jloehr commented Jan 23, 2018

Indeed, thanks for pointing that out 😄

@jloehr jloehr closed this in 11376d0 Mar 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.