Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ops and mem limits to pwhash functions #35

Merged
merged 4 commits into from Jan 15, 2020
Merged

Conversation

@ECrownofFire
Copy link
Contributor

@ECrownofFire ECrownofFire commented Oct 27, 2018

With these commits, the pwhash family of functions can accept either atoms (interactive, moderate, or sensitive) or positive integers (within crypto_pwhash_(OPS/MEM)LIMIT_(MAX/MIN)).

The versions that don't take limits are maintained, and simply default to interactive/interactive as they did before.

@ECrownofFire ECrownofFire force-pushed the ECrownofFire:master branch from a26b216 to 8c0917b Oct 27, 2018
It natively checks atoms, which is kinda messy, but it avoids having to
export the libsodium pwhash constants, which is nice.
@ECrownofFire ECrownofFire force-pushed the ECrownofFire:master branch from 8c0917b to 4afa6fc Oct 28, 2018
@jlouis
Copy link
Owner

@jlouis jlouis commented Nov 8, 2018

Nice work, I'll have a look and get it in over the next couple of days.

@jlouis jlouis merged commit 4afa6fc into jlouis:master Jan 15, 2020
@jlouis
Copy link
Owner

@jlouis jlouis commented Jan 15, 2020

I'm behind on these, but your changes are now merged into Master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants