Add ops and mem limits to pwhash functions #35
Merged
Conversation
It natively checks atoms, which is kinda messy, but it avoids having to export the libsodium pwhash constants, which is nice.
|
Nice work, I'll have a look and get it in over the next couple of days. |
|
I'm behind on these, but your changes are now merged into Master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
With these commits, the pwhash family of functions can accept either atoms (
interactive,moderate, orsensitive) or positive integers (withincrypto_pwhash_(OPS/MEM)LIMIT_(MAX/MIN)).The versions that don't take limits are maintained, and simply default to interactive/interactive as they did before.