Add feature to copy to clipboard#2
Merged
Merged
Conversation
cljoly
commented
Aug 17, 2022
cljoly
commented
Contributor
- refactor: early exit on error
- fix: spaces, global variable, variable name
- feat: add the ability to pass options to copy to clipboard
This makes the control flow easier to follow IMO.
This removes end of line spaces, a global variable (the `local` was likely forgotten) and rename a variable for clarity and to avoid a double `not`.
This preserves the previous behavior, where calling ``` :lua require"nvim-git-link".get_remote_link() ``` opens the web browser. See the changes made to the README for usage of the new option.
Owner
|
lgtm! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.