New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0] Protocols cleanup #454

Closed
jlu5 opened this Issue May 10, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@jlu5
Owner

jlu5 commented May 10, 2017

  • Clean up classes.Protocol and move IRC-specific code to ircs2s_common
  • Clean up code duplication between ts6_common and p10
    • PRIVMSG/NOTICE
    • INVITE
    • PART
  • Normalize function names to snake case (clientbot, classes.Protocol)
  • Clean up clientbot (remove duplication in nick collision checking, etc. defer because clientbot nick collision handling is different)
  • Prefix private functions with a _?

@jlu5 jlu5 added the enhancement label May 10, 2017

@jlu5 jlu5 added this to the v1.2 milestone May 10, 2017

jlu5 added a commit that referenced this issue May 10, 2017

@jlu5 jlu5 referenced this issue Jun 25, 2017

Merged

[WIP] IRC stack and protocol revamp #475

18 of 20 tasks complete

jlu5 added a commit that referenced this issue Jun 30, 2017

@jlu5 jlu5 modified the milestones: v2.0, v1.2 Jun 30, 2017

@jlu5 jlu5 changed the title from [1.2] Protocols cleanup to [2.0] Protocols cleanup Jun 30, 2017

@jlu5 jlu5 closed this Jun 30, 2017

@jlu5 jlu5 added the cleanup label Aug 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment