New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block device cannot be used as source (Linux, patch provided) #73

Closed
GoogleCodeExporter opened this Issue Mar 24, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Mar 24, 2015

> What steps will reproduce the problem?
1. losetup /dev/loop0 file1
2. losetup /dev/loop1 file2
3. xdelta3 -s /dev/loop0 /dev/loop1 delta 

> What is the expected output? What do you see instead?

Delta file should be generated without errors. Instead error message
"xdelta3: source file must be seekable: /dev/loop0" is printed.

> What version of the product are you using? On what operating system?

xdelta3.0t on Linux Fedora 9 (x86_64)

> Please provide any additional information below.

As block devices are seekable the error is not really true.

Current implementation only allows "regular" file as source and uses
information returned by stat for file size. To be able to use xdelta on
block devices two things must be done.

1) block device should pass the "seekable" test
2) as size of block device is not returned by stat an alternate method must
be implemented. (ioctl)

Patch providing the needed changes is attached.

Original issue reported on code.google.com by khau...@gmail.com on 15 May 2008 at 7:18

Attachments:

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 24, 2015

Thank you for your patch!
I have wanted to add support for using a fifo for the source file, but this 
approach
is more more useful.  I may not get to this very soon (lots of summer weddings, 
etc)
but really appreciate the help.

Original comment by josh.mac...@gmail.com on 11 Jun 2008 at 4:40

  • Changed state: Accepted

GoogleCodeExporter commented Mar 24, 2015

Thank you for your patch!
I have wanted to add support for using a fifo for the source file, but this 
approach
is more more useful.  I may not get to this very soon (lots of summer weddings, 
etc)
but really appreciate the help.

Original comment by josh.mac...@gmail.com on 11 Jun 2008 at 4:40

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 24, 2015

A FIFO as a source would be very useful too!

Original comment by zeev.tar...@gmail.com on 3 Sep 2008 at 5:33

GoogleCodeExporter commented Mar 24, 2015

A FIFO as a source would be very useful too!

Original comment by zeev.tar...@gmail.com on 3 Sep 2008 at 5:33

@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 24, 2015

SVN 292 supports fifo sources.

Original comment by josh.mac...@gmail.com on 26 Oct 2009 at 2:45

  • Changed state: Started

GoogleCodeExporter commented Mar 24, 2015

SVN 292 supports fifo sources.

Original comment by josh.mac...@gmail.com on 26 Oct 2009 at 2:45

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

Show comment
Hide comment
@GoogleCodeExporter

GoogleCodeExporter Mar 24, 2015

Original comment by josh.mac...@gmail.com on 26 Oct 2009 at 6:24

  • Changed state: Fixed

GoogleCodeExporter commented Mar 24, 2015

Original comment by josh.mac...@gmail.com on 26 Oct 2009 at 6:24

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment