Skip to content

jmarshallnz

  • New Zealand
  • Joined on Sep 18, 2010

Organizations

Team XBMC
jmarshallnz
  • jmarshallnz a46e548
    Merge pull request #4551 from Montellese/settings_language_fix
  • Sascha Montellese d18807c
    fix crash when changing the skin zoom from non-GUI thread (fixes #15114)
  • 1 more commit »
jmarshallnz merged pull request xbmc/xbmc#4551
jmarshallnz
fix crash when changing language from non-GUI thread (fixes #15113)
2 commits with 6 additions and 2 deletions
jmarshallnz
jmarshallnz merged pull request xbmc/xbmc#4560
jmarshallnz
changed: Don't try to sort subtitles, it screws up eg. sync priority
1 commit with 0 additions and 2 deletions
jmarshallnz
jmarshallnz merged pull request xbmc/xbmc#4491
jmarshallnz
Added optional parameter 'ignoreCache' to xbmc.playSFX()
1 commit with 29 additions and 7 deletions
jmarshallnz
jmarshallnz merged pull request xbmc/xbmc#4555
jmarshallnz
fix flickering music OSD
1 commit with 2 additions and 1 deletion
jmarshallnz commented on pull request xbmc/xbmc#4512
jmarshallnz

Nice work. Will review in detail post-Gotham. Regarding skins, IMO the small pain from requiring the IDs to be the same across the dialogs/windows …

jmarshallnz
jmarshallnz merged pull request xbmc/xbmc#4548
jmarshallnz
fix incorrect logging when using static ffmpeg
1 commit with 3 additions and 1 deletion
jmarshallnz commented on pull request xbmc/xbmc#4546
jmarshallnz

Looks OK to me. Would appreciate @elupus comments though.

jmarshallnz
jmarshallnz merged pull request xbmc/xbmc#4530
jmarshallnz
fix toggle fullscreen during video playback
1 commit with 25 additions and 1 deletion
jmarshallnz
  • jmarshallnz 014aab5
    Merge pull request #4478 from Montellese/upnp_controller
  • Sascha Montellese ed1e9eb
    upnp: unregister any discovered UPnP renderers when disabling the upn…
  • 1 more commit »
jmarshallnz merged pull request xbmc/xbmc#4478
jmarshallnz
Two UPnP controller related fixes
2 commits with 42 additions and 6 deletions
jmarshallnz commented on pull request xbmc/xbmc#4534
jmarshallnz

jenkins build this please

jmarshallnz commented on pull request xbmc/xbmc#4535
jmarshallnz

jenkins build this please

jmarshallnz commented on pull request xbmc/xbmc#4531
jmarshallnz

Looks good - assigned to H*

jmarshallnz commented on pull request xbmc/xbmc#4532
jmarshallnz

jenkins build this please

jmarshallnz commented on pull request xbmc/xbmc#4532
jmarshallnz

while you're at it?

jmarshallnz
jmarshallnz merged pull request xbmc/xbmc#4533
jmarshallnz
[gl/gles] - remove annoying kai toast in videofilter fallback case
1 commit with 0 additions and 4 deletions
jmarshallnz commented on pull request xbmc/xbmc#4491
jmarshallnz

ATM they're only free'd on UnLoad(), yes. This isn't called from anywhere as far as I can tell, other than Load(), so they just accumulate until th…

jmarshallnz commented on pull request xbmc/xbmc#4491
jmarshallnz

Thus the cache. i.e. LoadSound("foo"); LoadSound("foo"); FreeSound("foo"); still leaves foo around as it was loaded twice (presumably by different …

jmarshallnz

@pitakakariki I 'borrowed' that nice bit of code already in 7dd2d57 :)

jmarshallnz commented on commit xbmc/xbmc@fd2b4815d9
jmarshallnz

That's a separate issue. If you want plugins to provide richer metadata then you'd want the plugin to be able to tell the infomanager what type of …

jmarshallnz commented on pull request xbmc/xbmc#4491
jmarshallnz

Does it make more sense to have the default bool cache = true ? It seems 'wrong' to send a parameter equal to true to tell it to clear the cache. I…

jmarshallnz commented on pull request xbmc/xbmc#4526
jmarshallnz

Why not? Don't just say "no" without explanation. Users are complaining. They may be wrong, but how are others to know what your rationale is?

jmarshallnz
Something went wrong with that request. Please try again.