Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat callback like response #171

Closed

Conversation

jdietrich-tc
Copy link
Contributor

I found that the same logic wasn't being applied to do variable replacement in Responses and Callbacks. Headers in Callbacks for instance were not being replaced.

@jmartin82
Copy link
Owner

Hi, thanks for reporting this,

Can you take a look at #177 ? I tried to implement the same change you did here but only added few changes.

If you agree, I will close this one and apply the #177

@jdietrich-tc
Copy link
Contributor Author

Hi, thanks for reporting this,

Can you take a look at #177 ? I tried to implement the same change you did here but only added few changes.

If you agree, I will close this one and apply the #177

I agree. Looks good. Thanks

@jmartin82 jmartin82 closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants