Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can pass invalid args into headerline #5

Closed
jmaslak opened this issue Jul 14, 2018 · 2 comments
Closed

Can pass invalid args into headerline #5

jmaslak opened this issue Jul 14, 2018 · 2 comments

Comments

@jmaslak
Copy link
Owner

jmaslak commented Jul 14, 2018

Example that doesn't properly throw an exception:

use File::ByLine;

my $byline = File::ByLine->new();

$byline->header_handler("not code"); # Should die, but doesn't.
$byline->header_handler( [] ) }; # Should die, but doesn't
jmaslak added a commit that referenced this issue Jul 14, 2018
@jmaslak
Github issue #5 - _coderef() should properly detect non-coderefs
a811c1d
@jmaslak
Copy link
Owner Author

jmaslak commented Jul 14, 2018

I believe this is fixed in the current master branch, and will be releasing a dev branch. I'm keeping this open until I release a non-dev version with it.

jmaslak added a commit that referenced this issue Jul 14, 2018
@jmaslak
v1.181950
396bc00 
 Joelle Maslak <jmaslak@antelope.net>
 * TRIAL/DEV RELEASE ONLY
 * Bugfix: Github Issue #5 - Don't allow non-coderef as header_handler
 * Multifile Interface
jmaslak added a commit that referenced this issue Jul 14, 2018
@jmaslak
v1.181951
9028312 
 Joelle Maslak <jmaslak@antelope.net>
 * TRIAL/DEV RELEASE ONLY
 * From 1.181950 Bugfix: Github Issue #5 - Don't allow non-coderef as header_handler
 * From 1.181950 Multifile Interface
 * Preserve ordering for parallel map/grep multifile interfaces
 * Constructor accepts parameters now
 * Combine grep & map code
 * Can pass file() attribute either arrayref or list of files
 * Better attribute checking
 * Pass extended information hash (when extended_info is true) to all
   user provided code references.
 * Multifile Interface now allows header processing on a per-file basis
jmaslak added a commit that referenced this issue Jul 15, 2018
@jmaslak
v1.181962
82b9934 
 Joelle Maslak <jmaslak@antelope.net>
 * From 1.181951 Multifile Interface
 * From 1.181951 Constructor accepts parameters now
 * From 1.181951 Better attribute checking
 * From 1.181951 Pass extended information hash (when extended_info is true)
                 to all user provided code references.
 * From 1.181950 Bugfix: Github Issue #5 - Don't allow non-coderef as header_handler
 * Make tests more resiliant
jmaslak added a commit that referenced this issue Jul 17, 2018
@jmaslak
v1.181980
b08179f 
 Joelle Maslak <jmaslak@antelope.net>
 * TRIAL/DEV RELEASE ONLY
 * From 1.181951 Multifile Interface
 * From 1.181951 Constructor accepts parameters now
 * From 1.181951 Better attribute checking
 * From 1.181951 Pass extended information hash (when extended_info is true)
                 to all user provided code references.
 * From 1.181950 Bugfix: Github Issue #5 - Don't allow non-coderef as header_handler
 * Add skip_unreadable attribute, to skip over unreadable files
 * Add short version of attribute names
jmaslak added a commit that referenced this issue Jul 17, 2018
@jmaslak
v1.181981
be04f8a 
 * TRIAL/DEV RELEASE ONLY
 * From 1.181980 Add skip_unreadable attribute, to skip over unreadable
                 files.
 * From 1.181980 Add short version of attribute names
 * From 1.181951 Multifile Interface
 * From 1.181951 Constructor accepts parameters now
 * From 1.181951 Better attribute checking
 * From 1.181951 Pass extended information hash (when extended_info is true)
                 to all user provided code references.
 * From 1.181950 Bugfix: Github Issue #5 - Don't allow non-coderef as header_handler
 * Don't fail tests (04-attributes.t) when Parallel::WorkUnit not
   installed
jmaslak added a commit that referenced this issue Jul 18, 2018
@jmaslak
v1.181990
1c4660e 
 * From 1.181981 Don't fail tests (04-attributes.t) when Parallel::WorkUnit not
                 installed
 * From 1.181980 Add skip_unreadable attribute, to skip over unreadable
                 files.
 * From 1.181980 Add short version of attribute names
 * From 1.181951 Multifile Interface
 * From 1.181951 Constructor accepts parameters now
 * From 1.181951 Better attribute checking
 * From 1.181951 Pass extended information hash (when extended_info is true)
                 to all user provided code references.
 * From 1.181950 Bugfix: Github Issue #5 - Don't allow non-coderef as
                 header_handler
@jmaslak
Copy link
Owner Author

jmaslak commented Jul 18, 2018

Released

@jmaslak jmaslak closed this as completed Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmaslak