Skip to content

Justin Mason
jmason

Apr 11, 2016
jmason commented on issue relayrides/pushy#62
@jmason

I would be in favour of closing this, too. The primary use case was to deal with the rejected-notification-causes-connection-close lossage, which i…

Apr 11, 2016
jmason commented on pull request relayrides/pushy#266
@jmason

lgtm!

Apr 8, 2016
jmason commented on pull request relayrides/pushy#265
@jmason

I would be in favour of HTTP-level PINGs rather than relying on TCP Keep-Alive -- the latter is only manipulable on a system-wide level in Linux, a…

Mar 29, 2016
jmason commented on pull request relayrides/pushy#251
@jmason

:tada: looks awesome. looking forward to using this ;)

Mar 14, 2016
jmason commented on pull request relayrides/pushy#222
@jmason

cheers Jon ;)

Mar 14, 2016
jmason commented on pull request relayrides/pushy#251
@jmason

looks great!

Mar 14, 2016
jmason commented on pull request relayrides/pushy#251
@jmason

I would be inclined to create a NullMetricsListener class which just contains no-ops, and use that by default, in order to avoid the need to null-c…

Mar 4, 2016
jmason commented on issue getsentry/raven-java#151
@jmason

We just ran into this in production, too. It'd be nice to see it fixed

Feb 22, 2016
jmason commented on issue relayrides/pushy#175
@jmason

yep, the notificationId thing makes sense -- that gives us enough info for Timer usage.

Feb 22, 2016
jmason commented on issue relayrides/pushy#175
@jmason

Agreed that it would be better to get rid of the 'synchronized' scopes. I would say limiting to a single listener would be fine as a way to avoid t…

Feb 12, 2016
jmason commented on issue dropwizard/metrics#917
@jmason

actually, looking at that stack trace and the first comment, it looks like the problem is that it is catching and logging that exception -- but not…

Feb 12, 2016
jmason commented on issue dropwizard/metrics#917
@jmason

Unfortunately, the graphite protocol is one-way -- writes only, with nothing for the client to read, as far as I know. But shouldn't the write() ca…

Something went wrong with that request. Please try again.