New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for camera make and model in directory path #254 #255

Merged
merged 2 commits into from Nov 15, 2017

Conversation

Projects
None yet
2 participants
@jmathai
Owner

jmathai commented Oct 8, 2017

Needed before merging.

  • Add docs for EXIF fields used for make and model
  • Add tests for get_camera_make and get_camera_model
  • Add more tests for negative cases and fallback

@jmathai jmathai added the do not merge label Oct 8, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Oct 8, 2017

Coverage Status

Coverage decreased (-0.2%) to 93.082% when pulling 6f5e6f9 on camera-make-model-254 into fd3cab4 on master.

coveralls commented Oct 8, 2017

Coverage Status

Coverage decreased (-0.2%) to 93.082% when pulling 6f5e6f9 on camera-make-model-254 into fd3cab4 on master.

@jmathai jmathai referenced this pull request Oct 8, 2017

Closed

Retrieve camera model #254

@jmathai jmathai changed the title from Add support for camera make and model in directory path and file name #254 to Add support for camera make and model in directory path #254 Oct 8, 2017

@jmathai jmathai added the tests label Oct 8, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Nov 15, 2017

Coverage Status

Coverage decreased (-0.2%) to 93.096% when pulling da25d42 on camera-make-model-254 into 362b1b1 on master.

coveralls commented Nov 15, 2017

Coverage Status

Coverage decreased (-0.2%) to 93.096% when pulling da25d42 on camera-make-model-254 into 362b1b1 on master.

@jmathai jmathai merged commit 4cd91e9 into master Nov 15, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 93.096%
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment