New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reset_dbs() / restore_dbs() more robust #260 #263

Merged
merged 2 commits into from Dec 6, 2017

Conversation

Projects
None yet
4 participants
@jmathai
Owner

jmathai commented Dec 6, 2017

If reset_dbs() is called and the test errors restore_dbs() is not called. On Windows this leads to an error the next time they're called because ~/hash.json-test and ~/location.json-test still exist.

@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Dec 6, 2017

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Dec 6, 2017

CLA assistant check
All committers have signed the CLA.

@jmathai jmathai changed the title from Make reset_dbs() / restore_dbs() more robust to Make reset_dbs() / restore_dbs() more robust #260 Dec 6, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 6, 2017

Coverage Status

Coverage decreased (-1.9%) to 91.168% when pulling 12dff57 on reset_dbs_enhancement into 4cd91e9 on master.

coveralls commented Dec 6, 2017

Coverage Status

Coverage decreased (-1.9%) to 91.168% when pulling 12dff57 on reset_dbs_enhancement into 4cd91e9 on master.

TonyWhitley and others added some commits Dec 5, 2017

Make reset_dbs() / restore_dbs() more robust
If reset_dbs() is called and the test errors restore_dbs() is not called. On Windows this leads to an error the next time they're called because ~/hash.json-test and ~/location.json-test still exist.
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Dec 6, 2017

Coverage Status

Coverage increased (+0.03%) to 93.124% when pulling 596139d on reset_dbs_enhancement into 4cd91e9 on master.

coveralls commented Dec 6, 2017

Coverage Status

Coverage increased (+0.03%) to 93.124% when pulling 596139d on reset_dbs_enhancement into 4cd91e9 on master.

@jmathai

This comment has been minimized.

Show comment
Hide comment
@jmathai

jmathai Dec 6, 2017

Owner

@TonyWhitley tests are passing. If you can sign the CLA I will merge the PR. Click the link / button below.

CLA assistant check

https://cla-assistant.io/jmathai/elodie?pullRequest=263

Owner

jmathai commented Dec 6, 2017

@TonyWhitley tests are passing. If you can sign the CLA I will merge the PR. Click the link / button below.

CLA assistant check

https://cla-assistant.io/jmathai/elodie?pullRequest=263

@jmathai jmathai merged commit 8950f75 into master Dec 6, 2017

4 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+2.0%) to 93.124%
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment