Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix source files modified on import #252 #272
Conversation
This comment has been minimized.
This comment has been minimized.
CLAassistant
commented
Apr 5, 2018
•
This comment has been minimized.
This comment has been minimized.
Tests failing, will have a look |
This comment has been minimized.
This comment has been minimized.
Updated idea to tweak checksum/hashing logic |
This comment has been minimized.
This comment has been minimized.
I'll have a look at why these tests are failing as well. |
This comment has been minimized.
This comment has been minimized.
I have fixed some more tests locally but this PR is still a WIP. Realised I think I can tidy up to make use of exiftools -o flag, will investigate... |
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Apr 8, 2018
This comment has been minimized.
This comment has been minimized.
coveralls
commented
Apr 8, 2018
•
mattca
force-pushed the
mattca:source_files_are_modified_on_import_252
branch
from
4a15b0f
to
7937832
Apr 10, 2018
This comment has been minimized.
This comment has been minimized.
Had a look at making use of exiftools -o flag so we don't rely on the *_original file created. However, pyexiftool seems to break with this option. So leaving as it is. @jmathai can you review the PR, do you think we're OK to merge? Thanks! |
1 similar comment
This comment has been minimized.
This comment has been minimized.
Had a look at making use of exiftools -o flag so we don't rely on the *_original file created. However, pyexiftool seems to break with this option. So leaving as it is. @jmathai can you review the PR, do you think we're OK to merge? Thanks! |
jmathai
requested changes
Apr 21, 2018
This is great. Thanks for the PR and especially for updating the tests. I left a few minor comments. |
elodie/filesystem.py Outdated
elodie/filesystem.py Outdated
elodie/filesystem.py Outdated
elodie/filesystem.py Outdated
elodie/filesystem.py Outdated
elodie/filesystem.py Outdated
elodie/tests/filesystem_test.py Outdated
jmathai
added
bug
do not merge
labels
Apr 21, 2018
This comment has been minimized.
This comment has been minimized.
fredmorin
commented
Jan 2, 2019
Any chance this gets merged in the master branch? I'd like to use elodie, but do not want my original files to be modified. I attempted to import a folder and also noticed the issue. |
This comment has been minimized.
This comment has been minimized.
This PR is next on my list to get merged. I've lost most of the context around it but will try and ramp up again. |
This comment has been minimized.
This comment has been minimized.
Hi, apologies, I know it's been a while but I'd like to pick this back up. Will have another look sometime this week. Have also lost track but I think I just need to look into restoring the timestamp. Will give you an update on how it goes. |
mattca
added some commits
Jan 24, 2019
mattca
force-pushed the
mattca:source_files_are_modified_on_import_252
branch
from
7bc803a
to
7b04af1
Jan 24, 2019
mattca
added some commits
Jan 24, 2019
This comment has been minimized.
This comment has been minimized.
OK, @jmathai can you re-review? I rebased on most recent code and made some final tweaks. Tests now passing and did a small test locally and the checksums etc seem fine. Had to do a bit of a hack around the text file, am having to copy that to an "_original" file as well in the same way exiftool does. Seems to work.. Haven't tried it with lots of files yet, will do a more real world test just to be confident when I get a second. |
This comment has been minimized.
This comment has been minimized.
Thanks! I'm traveling the next few days but will have a look early next week. |
This comment has been minimized.
This comment has been minimized.
Hey @mattca -- Looks great. I've submitted a PR against your branch and can merge into here once you merge there. |
jmathai
approved these changes
Feb 4, 2019
jmathai
merged commit 2e2c103
into
jmathai:master
Feb 4, 2019
jmathai
removed
the
do not merge
label
Feb 4, 2019
This comment has been minimized.
This comment has been minimized.
Thanks @mattca! |
mattca commentedApr 5, 2018
No description provided.