New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package Elodie up as a Python PIP module #303

Open
wants to merge 7 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@lukeplausin
Copy link

lukeplausin commented Feb 10, 2019

Hi Jaisen,

I read your blog about the Elodie project, and I really like the idea. I've been experimenting a little bit with Elodie, I think it's a great project and I'd like to contribute.

I made some changes on my fork to package Elodie up as a PIP module. This basically allows you to do some nice things using Pip:

  • You can install Elodie and all python dependencies using a one line command, and without needing to use git (this is probably a bit nicer for newbies):
    pip install git+https://github.com/jmathai/elodie.git
  • The PBR packaging for pip includes CLI hooks, so you can invoke elodie as a CLI tool from any location:
cd (my pics folder)
elodie --source (my sd card) --destination .
  • You can install elodie in developer mode to the current environment - this allows you to make changes on the fly without reinstalling the module
cd (elodie github repo)
pip install -e .
  • There is the future possibility to upload Elodie to the Python module index, so that it can be downloaded with pip in the same was as other public modules

Anyway, please let me know if you like it. If not I can change a few things around. I tested the electron app also and it seems to be working.

Luke

@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Feb 10, 2019

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Luke Plausin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Feb 10, 2019

Coverage Status

Coverage decreased (-1.6%) to 89.008% when pulling a447c88 on lukeplausin:master into 2e2c103 on jmathai:master.

@jmathai
Copy link
Owner

jmathai left a comment

Thanks for the PR. Left a few comments.

@@ -15,7 +15,7 @@
sys.path.insert(0, os.path.abspath(os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname(os.path.realpath(__file__)))))))

import helper
elodie = load_source('elodie', os.path.abspath('{}/../../elodie.py'.format(os.path.dirname(os.path.realpath(__file__)))))
elodie = load_source('elodie', os.path.abspath('{}/../elodie.py'.format(os.path.dirname(os.path.realpath(__file__)))))

This comment has been minimized.

@jmathai

jmathai Feb 13, 2019

Owner

Is changing this path what's causing the tests to fail in Python 2.7?
https://travis-ci.org/jmathai/elodie/jobs/491249606

This comment has been minimized.

@lukeplausin

lukeplausin Feb 15, 2019

Author

I'm not exactly sure why the build is failing in 2.7, it doesn't seem to be an import error though. I haven't had time to investigate the 2.7 failure yet

@@ -29,12 +29,10 @@ dnf install perl-Image-ExifTool

### Clone the Elodie repository

You can clone Elodie from GitHub. You'll need `git` installed ([instructions](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git)).
You can clone Elodie from GitHub. You'll need `pip` and `git` installed ([instructions](https://git-scm.com/book/en/v2/Getting-Started-Installing-Git)).

This comment has been minimized.

@jmathai

jmathai Feb 13, 2019

Owner

Can update this to either clone from Github or install via pip. Don't need both.

This comment has been minimized.

@lukeplausin

lukeplausin Feb 15, 2019

Author

I believe you do still need git installed if you're installing via pip+git. If Elodie is accepted into the pypa public python repository then you wouldn't need git anymore.

@@ -10,3 +10,129 @@ build/**
**/*.nef
**/*.rw2
env/**

This comment has been minimized.

@jmathai

jmathai Feb 13, 2019

Owner

Are most of these standard excludes or related to packaging for pip? Was just curious - no change needed.

This comment has been minimized.

@lukeplausin

lukeplausin Feb 15, 2019

Author

These are standard includes for python. The python compiler will add files to the repo which will get checked into git unless they're excluded by .gitignore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment