Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add capitalization option for [File] config #313

Merged
merged 2 commits into from Jun 12, 2019

Conversation

Projects
None yet
4 participants
@muff1nman
Copy link
Contributor

commented Jun 11, 2019

No description provided.

@CLAassistant

This comment has been minimized.

Copy link

commented Jun 11, 2019

CLA assistant check
All committers have signed the CLA.

@muff1nman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

Addresses #312

@coveralls

This comment has been minimized.

Copy link

commented Jun 11, 2019

Coverage Status

Coverage increased (+0.03%) to 89.875% when pulling f6b195e on muff1nman:case-config into 23e3b45 on jmathai:master.

@jmathai

This comment has been minimized.

Copy link
Owner

commented Jun 11, 2019

Thanks @muff1nman. Can we add a test for this configuration?

Should be able to copy/paste this test for starters and run the following command and updating using whatever you name your test.

nosetests elodie/tests/filesystem_test.py:test_get_file_name_custom_with_empty_value
.
----------------------------------------------------------------------
Ran 1 test in 1.705s

OK
@muff1nman

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

Done.

@jmathai jmathai merged commit 9260576 into jmathai:master Jun 12, 2019

4 checks passed

Scrutinizer Analysis: 3 new issues, 3 updated code elements – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.03%) to 89.875%
Details
license/cla Contributor License Agreement is signed.
Details
@jmathai

This comment has been minimized.

Copy link
Owner

commented Jun 12, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.